-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add origin_referrer_url
, origin_url
and zone_identifier
to the process attribute
#1517
Open
AsuNa-jp
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
AsuNa-jp:process_events_fileorigins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add origin_referrer_url
, origin_url
and zone_identifier
to the process attribute
#1517
AsuNa-jp
wants to merge
11
commits into
open-telemetry:main
from
AsuNa-jp:process_events_fileorigins
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisch-me
reviewed
Oct 25, 2024
Co-authored-by: Alexandra Konrad <alexandra.konrad@elastic.co>
trisch-me
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the following attributes.
process.origin_referrer_url
process.origin_url
process.zone_identifier
Details
Generally, a process is generated from an executable file. Therefore, the process model naturally includes attributes containing information about the originating executable file. In this PR, we are adding the following three attributes to further extend the originating executable file details.
process.origin_referrer_url
process.origin_url
process.zone_identifier
The name of these attributes and where to add it were decided after consulting with @joe-desimone and @trisch-me.
The meaning of each field is explained in detail in the PR below.
Merge requirement checklist
[chore]