fix(release): don't persist credentials when checking out the repo #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow semantic release to use the passed github token to use git
tagoro9
force-pushed
the
f/checkout_without_persisting_credentials_on_release
branch
from
9a8a392 to
9b02bed
Compare
| @@ -36,7 +36,8 @@ runs: | |||
| uses: actions/checkout@v3 | |||
| if: inputs.checkout-repo | |||
| with: | |||
| fetch-depth: 0 | |||
| fetch-depth: ${{ inputs.checkout-repo == 'true' && 0 || 1 }} | |||
| persist-credentials: false | |||
There was a problem hiding this comment.
Interesting @tagoro9 , is this something we should be doing across all of the open-turo repos?
There was a problem hiding this comment.
I'm testing this after we merge it, so it may need to be needed (if we want to allow semantic release to commit / push using the passed Github token)
dgschwindturo
approved these changes
Dec 19, 2022
tagoro9
deleted the
f/checkout_without_persisting_credentials_on_release
branch
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes originates from semantic-release/git#196. Trying to get to use semantic-release/git in combination with this action. In order for this to work, we have to be able to get semantic release to use the passed
GITHUB_TOKENinstead of the default git configuredChanges
🚀 PR created with fotingo