Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): don't persist credentials when checking out the repo #17

Merged
merged 1 commit into from
Dec 19, 2022
Merged

fix(release): don't persist credentials when checking out the repo #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion release/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ runs:
uses: actions/checkout@v3
if: inputs.checkout-repo
with:
fetch-depth: 0
fetch-depth: ${{ inputs.checkout-repo == 'true' && 0 || 1 }}
persist-credentials: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting @tagoro9 , is this something we should be doing across all of the open-turo repos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing this after we merge it, so it may need to be needed (if we want to allow semantic release to commit / push using the passed Github token)

- name: Setup tools
uses: open-turo/action-setup-tools@v1
- name: Install dependencies
Expand Down