Ember CLI v2.12 -> v2.13 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexdiliberto 👍 You mind also committing you |
crodriguez1a
approved these changes
Jun 8, 2017
|
ping @jbailey4 |
jbailey4
reviewed
Jun 10, 2017
There was a problem hiding this comment.
@alexdiliberto LGTM. Only question I have is the deletion of the LICENSE file, is that part of the upgrade?
|
@jbailey4 We have 2 license files here for some reason, I'm deleting the one that's not auto generated by CLI |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to CLI v2.13 and remove all console warnings
Additionally, Locking bulma at 0.1.2 as well -- I was seeing some visual diffs when updating to latest (@jbailey4) -- See #63