Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bulma version #66

Closed
wants to merge 1 commit into from
Closed

Conversation

jeanlucaslima
Copy link
Collaborator

@jeanlucaslima jeanlucaslima commented Jul 12, 2017

Fixes #65

@alexdiliberto
Copy link
Contributor

alexdiliberto commented Jul 13, 2017

Hey @jeanleonino Thank you for your PR! Unfortunately right now we cannot simply make this version bump update to latest. We use this CSS framework as the base layer for a large production application and going from Bulma v0.1.2 to v0.4.3 would "break" our app visually and allow a tougher gradual upgrade process.

The idea is that we slowly upgrade our way to latest or 0.4.3 while addressing visual inconsistencies along the way. We would welcome any other PRs to help us gradually upgrade like tests, etc.

For some historical context for what I'm talking about you can see the following:
#63
#62 (comment)

I'll let @crodriguez1a and @jbailey4 chime in here if they wan't to provide any other feedback

@jbailey4
Copy link
Member

@alexdiliberto Maybe we should take this Bulma update and release an alpha or canary version. That way others can get this update, test it out, and submit fixes. The same would apply to our prod app, we can bump to the alpha release and test it out.

/cc @crodriguez1a

@crodriguez1a
Copy link
Member

crodriguez1a commented Jul 13, 2017

I think @jbailey4 idea is an excellent one. A canary or an alpha would be a good way to preview Bulma's updates. @jeanleonino Would you want to take that on, and maybe add a few tests along the way?

cc/ @alexdiliberto

Copy link
Member

@jbailey4 jbailey4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanleonino We also need to update the default blueprint, to include the latest bulma version when the addon is installed -> https://github.com/open-tux/ember-bulma/blob/master/blueprints/ember-bulma/index.js#L16

@jlegrone
Copy link
Contributor

jlegrone commented Aug 4, 2017

Thanks for raising this @jeanleonino! I'm closing in favor of #71 (bumps to latest bulma version); a new ember-bulma version should be released shortly.

@jlegrone jlegrone closed this Aug 4, 2017
@jlegrone
Copy link
Contributor

jlegrone commented Aug 7, 2017

@jeanleonino this is released in 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants