Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ section in navDrawer #116

Closed
wants to merge 1 commit into from
Closed

Conversation

ashwinkey04
Copy link
Contributor

Fixes #73

Screenshot (Device: Asus Max Pro M2 , ROM: OxygenOS 10)

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@ashwinkey04 ashwinkey04 marked this pull request as ready for review January 19, 2020 06:38
@rchtgpt
Copy link
Member

rchtgpt commented Jan 19, 2020

hey @ashwinkey04, we are currently working on a complete redesign of Mifos Mobile CN. The redesign does not have this navigation drawer.

@ashwinkey04 ashwinkey04 removed the request for review from therajanmaurya January 19, 2020 07:59
@ashwinkey04
Copy link
Contributor Author

Hey @Rachittt Thanks for your inputs. Will the options in the navDrawer be moved to some other menu in, say settings?

@ashwinkey04 ashwinkey04 removed the request for review from abhijitramesh January 19, 2020 15:52
@rchtgpt
Copy link
Member

rchtgpt commented Jan 19, 2020

Hey @Rachittt Thanks for your inputs. Will the options in the navDrawer be moved to some other menu in, say settings?

Yes, it will be there on the top left corner of the profile menu. Check the screenshot in #112

@rchtgpt
Copy link
Member

rchtgpt commented Jan 20, 2020

@ashwinkey04 Squash the commits

Use toaster from Utils
@garvit984
Copy link
Collaborator

@ashwinkey04 The app has been redesigned so this PR is now not relatable.

@ashwinkey04 ashwinkey04 closed this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add faq section in navigation drawer
4 participants