-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign: Customer profile activity #112
base: redesign
Are you sure you want to change the base?
Conversation
hey, I think you missed the navigation drawer icon on the top left, cause it's present in the mock-up. |
e1274ad
to
322f556
Compare
Try placing the camera icon around the circle image view. |
@luckyman20 done :) |
hey @Rachittt, you'll have to add all the hex codes and dimensions in the colors.xml and dimens.xml respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
11d23a1
to
740281b
Compare
before adding the fonts, I believe it is necessary to get an official approval from the admins on which font should be used for which kind of text, because it should be strictly uniform throughout the application. |
I think we should follow the same font pattern as in the mockups as that is what the mentor approved. Can you let me know what font you used for which kind of text? I've already used the fonts in my PRs. Please review them and let me know which one is wrong as I had to make some guesses because of the size of the mock-up. |
The text color of the textbox as per the mockup is not grey. There are also some inconsistencies in comparison to original design. |
Yeah, during GCI, the project maintainers asked me to make those changes hence you will find inconsistencies in comparison to the original design in almost all redesign PRs, but I am sure those are intentional as long as they don't look aesthetically unappealing. |
@Rachittt The editext for email and mobile number in these designs asks for input on being clicked. |
Fixes Issue
Fixes #105
Screenshot
Description
I have not added the bottom navigation because a lot of other activities would be involved. Hence, I believe addition of bottom navigation bar should be done in a separate PR. Would like to know the views of the project maintainers on it.
Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.