redesign: add all dimens #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchtgpt
reviewed
Jan 26, 2020
|
@luckyman20 all the negative dimensions are used for the bottom margin of CardView. I think it should be uniform for all the cards. Can you tell which dimension out of the three(-50,-40 and -30) should be used? |
|
@Rachittt Can you please post screenshot for all 3? It would help me in accessing it better. |
|
@luckyman20 Check the screenshots in the following PRs: |
|
@Rachittt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that there are similarities in dimens additions in #119, #117, #112, #110 etc. To avoid merge conflicts, I've compiled all additions into one PR. The dimens additions from all PRs can be removed after this PR gets merged.
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.