-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign: Add Beneficiaries and Show Beneficiaries Screen #119
base: redesign
Are you sure you want to change the base?
Conversation
hey @Rachittt, i think you should make a recycler view completely. you can add the card design as the item and an adapter to adapt the item layout to the recycler view as I think it is part of the frontend. |
036d68e
to
6347a04
Compare
Thanks for your comment! I have added a recyclerView with dummy details :D |
d211a77
to
65afec5
Compare
app/src/main/kotlin/org/mifos/mobile/cn/data/models/beneficiaries/listBeneficiaries.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/beneficiaries/BeneficiariesActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/beneficiaries/BeneficiariesActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/beneficiaries/BeneficiariesActivity.kt
Outdated
Show resolved
Hide resolved
dc560e5
to
d6ce7a8
Compare
updated! |
The button says "Submit Beneficiaries" but I think it should say "Submit Beneficiary". |
Also, you can see the bottom corner radius of the CardView which I think affects the UI. |
1854038
to
741653e
Compare
@laxyapahuja, thanks for pointing out! Made the changes. |
app/src/main/kotlin/org/mifos/mobile/cn/data/models/beneficiaries/listBeneficiaries.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/org/mifos/mobile/cn/ui/adapter/BeneficiariesAdapter.kt
Show resolved
Hide resolved
4c90673
to
ac42117
Compare
7c30485
to
836ee94
Compare
6723184
to
139c6bb
Compare
0482fed
to
1d05b95
Compare
For some of the devices, the grey card just overlaps the heading. There should be a scroll view for adding a new beneficiary. |
@Rachittt Can you please look into the changes requested above by me? |
Fixes Issue
Fixes #106
GIF
Description
I have not added the fonts and bottom navigation bar as they would be added in a different PR to prevent merge conflicts. I have added a sample recyclerView as well.
The color of the focused button is not the same as the mockup because this looked better in terms of design and contrast.
Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.