Feat: #896 Add error message for all fields in RegistrationFragment #907

letelete · 2018-10-24T17:11:47Z

Add error message for all fields.

Input error preview

miPlodder · 2018-10-24T17:55:50Z

build.gradle

@@ -19,8 +19,8 @@ buildscript {

 allprojects {
    repositories {
-        jcenter()
        google()


@letelete Undo this change

Pull request #909 covers this change, and a fix for multidex

miPlodder · 2018-10-24T17:56:05Z

app/src/main/java/org/mifos/mobilebanking/ui/views/RegistrationView.java

@@ -1,5 +1,7 @@
 package org.mifos.mobilebanking.ui.views;

+import android.widget.EditText;


@letelete Undo this change

miPlodder · 2018-10-24T17:58:16Z

@letelete Fix the Travis Build failed and add proper GIF showing UI changes.
Moreover, instead of creating multiple commits for small functionality change, create a single commit for the issue.

letelete · 2018-10-24T19:00:07Z

Is there any way to edit these, already existing commits and squash them all into one? I'm not sure how can I could've done that. Thought it's being done by a person who's merging the PR.

letelete · 2018-10-24T19:08:52Z

@miPlodder travis failed with Execution failed for task ':app:getDependencies'., which I've struggled with when first time cloning a repo. I fixed it on my machine by moving google() before jcenter() in build.gradle

miPlodder · 2018-10-25T04:52:56Z

@letelete You can use this link to squash the commit to one. Its job of the developer to maintain a clean Commit history.

@miPlodder Travis failed with Execution failed for task ':app:getDependencies'., which I've struggled with when first time cloning a repo. I fixed it on my machine by moving google() before jcenter() in build.gradle

Create an issue for Travis Build failed to explain what's happening. I will look into it.

miPlodder · 2018-10-25T04:55:18Z

app/src/main/java/org/mifos/mobilebanking/ui/fragments/RegistrationFragment.java

@@ -115,61 +151,153 @@ public void registerClicked() {
    }

    private boolean areFieldsValidated() {


@letelete What you are doing is correct. But instead of creating methods for every if, write them in a single method like it was written before.

@miPlodder Isn't it a bad practice to create long methods?

It's so unreadable and hard to maintain if the single method contains all of the validation logic. It's also easy to repeat yourself here, and that's what I've seen in your code before my fix. There were 2 validations for some of the input (I guess it was a password) which was checking if password length is greater than a) 5, b) 6 which is complete nonsense and it 100% comes out of hard-to-read method with tons of validations.

I've also seen validations for some specific inputs which were not grouped-up so at the beginning I could spot X validation and at the end of the method, I could also spot validation for the same X input.

My solution ensures clean-code standards. Methods are easy to maintain now and if we want to change some of the validation we just need to search for a specific method instead of analyzing one, enormous method.

Splitting validations into method has also another positive aspect, which is a fact, that with the live-update feature, we don't need to check every single validation and just the one we are interested in(validation for currently edited input).

@letelete I know that your code is cleaner. But I have a better alternative which I will add to the GCI tasks in future.
We can create a Utils Class where we can add all the validations methods (like you added here). By that way, we can call those methods, for any of the EditText (like Sign up, Login) where that validation is required. This will reduce redundant code for validation.

Yeah, that's actually a good idea which I was thinking about when faced with writing the same code for login_activity validation(#911) 😆 I will get all of these and split them into one as it was before, then.

letelete · 2018-10-25T08:02:52Z

I've added an issue describing the build problem #910

letelete · 2018-10-25T09:57:44Z

Fixing the bug described in #910 makes build successful. I thought you would like me to remove gradle.build change since It's not the PR for that.

letelete · 2018-10-25T14:36:57Z

@miPlodder Done. Btw. I've removed live update feature for now and will add it again when Utill class is ready.

miPlodder · 2018-10-27T12:42:00Z

app/src/main/java/org/mifos/mobilebanking/ui/fragments/RegistrationFragment.java

@@ -96,12 +99,6 @@ public void registerClicked() {
            payload.setFirstName(etFirstName.getText().toString());
            payload.setLastName(etLastName.getText().toString());
            payload.setMobileNumber(etPhoneNumber.getText().toString());
-            if (!etPassword.getText().toString().equals(etConfirmPassword.getText().toString())) {


@letelete Good fix here. 👍

letelete · 2018-10-27T22:18:09Z

@miPlodder Add request view feature which I told you about earlier. Speaking about live update validation. I would like to add it later when we will create separate validation class which you were talking about.

Preview

…atures Add error display for every input field. All of them can appear at once now. Add feature which find the first invalid input and force request on it with automatically appearing keyboard to help user correct it instantly. Fix validation logic. Add live update feature

letelete · 2018-10-31T21:35:44Z

Add new validation logic

If the input has focus for the first time:
- don't use live-update validation
If user left inputX (and move to inputY):
- check correctness of inputX
  - if invalid - show error
If user back to the previous input (in this case: from inputY to inputX) AND input is invalid:
- turn on live-update
if user back to the previous VALID input
- don't use live-update validation
On register button click:
- show error for every invalid input
- turn on live-update validation for every input
- move to the first invalid input and request focus on it
- force keyboard

miPlodder · 2018-11-03T18:28:44Z

@letelete You logic is inconsistent. Try different combination on the device. You can work on this in your spare time. You can focus on newer tasks.

miPlodder · 2019-01-01T04:49:59Z

@letelete Good job, but we are coming up with new design for Sign-Up in which we are splitting the fields in different fragments which makes this PR obsolete. Anyways good job here.

letelete mentioned this pull request Oct 24, 2018

Error text beneath EditText should be shown for all the EditText on clicking the Sign Up Button #896

Closed

miPlodder reviewed Oct 24, 2018

View reviewed changes

letelete mentioned this pull request Oct 24, 2018

Snackbar Fix (#899) #908

Closed

3 tasks

miPlodder reviewed Oct 25, 2018

View reviewed changes

letelete force-pushed the issue#869 branch from 8431e7c to 46e341c Compare October 25, 2018 06:48

letelete mentioned this pull request Oct 25, 2018

Bug: Unresolved dependencies error while building app #910

Closed

letelete force-pushed the issue#869 branch from 46e341c to d51309a Compare October 25, 2018 09:57

letelete force-pushed the issue#869 branch 2 times, most recently from b6ecc5a to 09e0722 Compare October 25, 2018 14:35

letelete changed the title ~~Feat: #896 Add error message for all fields, add live update validation~~ Feat: #896 Add error message for all fields Oct 25, 2018

letelete changed the title ~~Feat: #896 Add error message for all fields~~ Feat: #896 Add error message for all fields in RegistrationFragment Oct 25, 2018

letelete force-pushed the issue#869 branch from 09e0722 to e20077c Compare October 26, 2018 17:55

miPlodder reviewed Oct 27, 2018

View reviewed changes

letelete force-pushed the issue#869 branch 2 times, most recently from f188144 to a75fd66 Compare October 27, 2018 22:10

miPlodder mentioned this pull request Oct 29, 2018

Fix #895: Add error text below password EditText in LoginActivity #913

Merged

3 tasks

letelete force-pushed the issue#869 branch from a75fd66 to 27c4cbf Compare October 31, 2018 21:23

miPlodder closed this Jan 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: #896 Add error message for all fields in RegistrationFragment #907

Feat: #896 Add error message for all fields in RegistrationFragment #907

letelete commented Oct 24, 2018 •

edited

Loading

miPlodder Oct 24, 2018

etlhsu Oct 24, 2018

miPlodder Oct 24, 2018

miPlodder commented Oct 24, 2018 •

edited

Loading

letelete commented Oct 24, 2018

letelete commented Oct 24, 2018 •

edited

Loading

miPlodder commented Oct 25, 2018

miPlodder Oct 25, 2018

letelete Oct 25, 2018 •

edited

Loading

miPlodder Oct 25, 2018

letelete Oct 25, 2018 •

edited

Loading

letelete commented Oct 25, 2018 •

edited

Loading

letelete commented Oct 25, 2018 •

edited

Loading

letelete commented Oct 25, 2018

miPlodder Oct 27, 2018

letelete commented Oct 27, 2018

letelete commented Oct 31, 2018 •

edited

Loading

miPlodder commented Nov 3, 2018

miPlodder commented Jan 1, 2019

		@@ -1,5 +1,7 @@
		package org.mifos.mobilebanking.ui.views;

		import android.widget.EditText;

		@@ -115,61 +151,153 @@ public void registerClicked() {
		}

		private boolean areFieldsValidated() {

Feat: #896 Add error message for all fields in RegistrationFragment #907

Feat: #896 Add error message for all fields in RegistrationFragment #907

Conversation

letelete commented Oct 24, 2018 • edited Loading

Input error preview

miPlodder Oct 24, 2018

Choose a reason for hiding this comment

etlhsu Oct 24, 2018

Choose a reason for hiding this comment

miPlodder Oct 24, 2018

Choose a reason for hiding this comment

miPlodder commented Oct 24, 2018 • edited Loading

letelete commented Oct 24, 2018

letelete commented Oct 24, 2018 • edited Loading

miPlodder commented Oct 25, 2018

miPlodder Oct 25, 2018

Choose a reason for hiding this comment

letelete Oct 25, 2018 • edited Loading

Choose a reason for hiding this comment

miPlodder Oct 25, 2018

Choose a reason for hiding this comment

letelete Oct 25, 2018 • edited Loading

Choose a reason for hiding this comment

letelete commented Oct 25, 2018 • edited Loading

letelete commented Oct 25, 2018 • edited Loading

letelete commented Oct 25, 2018

miPlodder Oct 27, 2018

Choose a reason for hiding this comment

letelete commented Oct 27, 2018

Preview

letelete commented Oct 31, 2018 • edited Loading

Add new validation logic

miPlodder commented Nov 3, 2018

miPlodder commented Jan 1, 2019

letelete commented Oct 24, 2018 •

edited

Loading

miPlodder commented Oct 24, 2018 •

edited

Loading

letelete commented Oct 24, 2018 •

edited

Loading

letelete Oct 25, 2018 •

edited

Loading

letelete Oct 25, 2018 •

edited

Loading

letelete commented Oct 25, 2018 •

edited

Loading

letelete commented Oct 25, 2018 •

edited

Loading

letelete commented Oct 31, 2018 •

edited

Loading