Fix: Improved multidex and repository declaration #909
Conversation
|
@therajanmaurya and @miPlodder, it seems that contributors are having the issue that my patch solves, people cannot build the project without my change. You may want to consider address my pull request. |
|
@ethan627hsu I have not faced any issues. What was the build issue that you were facing? Create an issue for it. |
|
@miPlodder Some contributors face an issue where when building, Gradle gets confused about the support library and multidex. I've faced these problems locally, and when using Travis CI. The changes proposed will fix these issues, as some pull requests from others try to patch the issue within their functional solution. |
| google() | ||
| jcenter() |
There was a problem hiding this comment.
@ethan627hsu Why are you swapping these lines? This issue can be resolved by adding multi-dex dependency.
There was a problem hiding this comment.
@miPlodder The swapping prevents an error when referencing recyclerview in gradle
There was a problem hiding this comment.
@ethan627hsu Can you add the reference/link from where you got this solution?
There was a problem hiding this comment.
@miPlodder A user on StackOverflow also experienced my same issue. Here was his solution.
app/build.gradle
Outdated
| @@ -134,5 +134,7 @@ dependencies { | |||
| androidTestImplementation "com.android.support.test.espresso:espresso-core:$rootProject.espressoVersion" | |||
| androidTestImplementation "com.android.support.test:runner:$rootProject.runnerVersion" | |||
| androidTestImplementation "com.android.support.test:rules:$rootProject.rulesVersion" | |||
|
|
|||
There was a problem hiding this comment.
@ethan627hsu Add this as last implementation statement, that is above testImplementation and androidTestImplementation.
There was a problem hiding this comment.
Ok, added the change @miPlodder
|
@ethan627hsu Change the commit message to |
|
@miPlodder I added a modified commit message to the commit. |
|
@miPlodder Do I need to make any other additional changes? |
Fix #910: Unresolved dependencies error while building app
The commit fixes issues where certain references caused issues when building project