Fix #899: Replaced Snackbar with Toast in Recent Transactions #914
Conversation
|
@MigDinny Instead of removing the Snackbar, add a Toast message and fix the conflict. Follow commit instructions and change the commit message accordingly. |
|
I thought you asked in the issue to remove snackbar and not replace it. I’m confused now... should I replace it with a toast? About the build errors, I think they are fixed in another PR created by another student. Should I do the same to mine or wait that his PR gets merged? |
Yes, I know that. I think that informing the user via Toast message will serve a purpose in future, whereas Snackbar will do the same, but the UX will be better in case of Toast. Yes, pull the development branch, when it will get merged. Currently, it is being reviewed by other maintainers. |
|
Ok. Will do it when I get home. I’m in school right now. |
|
@miPlodder Created the toast. Updated it with the new merge. |
app/build.gradle
Outdated
| @@ -116,6 +116,9 @@ dependencies { | |||
| //mifos passcode | |||
| implementation "com.mifos.mobile:mifos-passcode:$mifosPasscodeVersion" | |||
|
|
|||
| //multidex | |||
There was a problem hiding this comment.
@MigDinny Remove this and pull the recent changes.
There was a problem hiding this comment.
@MigDinny You have not pulled the changes properly. Check out this PR (https://github.com/openMF/mifos-mobile/pull/915/files or any other updated PR). It doesn't contain it.
|
@MigDinny Change the commit message, |
MigDinny
changed the title
app/build.gradle
Outdated
| @@ -116,6 +116,9 @@ dependencies { | |||
| //mifos passcode | |||
| implementation "com.mifos.mobile:mifos-passcode:$mifosPasscodeVersion" | |||
|
|
|||
| //multidex | |||
There was a problem hiding this comment.
@MigDinny You have not pulled the changes properly. Check out this PR (https://github.com/openMF/mifos-mobile/pull/915/files or any other updated PR). It doesn't contain it.
| * Shows a Toast message | ||
| * @param message | ||
| */ | ||
| public void showToastMessage(String message) { |
There was a problem hiding this comment.
Don't create new method.
Use this method provided here.
| .append(' ') | ||
| .append(integersOfDate.get(0)); | ||
|
|
||
| if (integersOfDate != null) { |
|
@miPlodder Fixed the PR. The gradle changes etc are fixed. About the showToast() I managed to access the Activity and call BaseActivity.showToast() through RecentTransactionsFragment. |
|
@miPlodder I don't really know why bots are failing to build this. This PR is updated with development branch and I literally changed nothing but a few lines of code which have nothing to do with gradle. |
The number of lines of changes is less, it will be better you create a new branch and start fresh. |
|
@miPlodder Ok, will do it. What empty method were you talking about in GCI task? |
| @@ -42,6 +42,8 @@ | |||
|
|
|||
| void showMessage(String message); | |||
|
|
|||
| void showToastMessage(String message); | |||
There was a problem hiding this comment.
@MigDinny I meant to remove this and write code show message in showMessage()
There was a problem hiding this comment.
I didn't want to do it because it would probably ruin other showMessage() callings where a snackbar is the expected behavior.
I will close this PR and create a new one with a new branch
Fixes #899
Removed "No more transactions available" snackbar from the app.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
Squashed them into 1 commit.
Awaiting response.