Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py for sdist #240

Merged
merged 1 commit into from
Oct 4, 2018
Merged

setup.py for sdist #240

merged 1 commit into from
Oct 4, 2018

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jun 11, 2018

Developed a setup.py for python-level install from source (actually compiling!).

I am not sure it it does more harm than good to expose this to the user or if I should hide a perfectly tailored, PyPI distribution building only, setup.py deep in the source tree. Or I just keep this not as a documented (aka recommended) install method.

I will keep this here for now for documentation purposes.

Done:

  • sdist

Intentionally skipepd:

  • bdist_wheel: fully static, non-MPI
    • linux: manylinux2010 PEP571
    • win: mingw (no std::future support as of 7.0) -> VC 2015? PEP?
    • osx: apple clang? PEP?

setup.py Outdated
'Topic :: Scientific/Engineering',
'Topic :: Database :: Front-Ends',
'Programming Language :: C++',
'Programming Language :: Python',
Copy link
Member Author

@ax3l ax3l Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line probably needs to go to make sure it's really just matching Python 3 on PyPI and a pip2 install openpmd-api can fail early.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, it's python_requires for setuptools on PyPI.
(ref)

@ax3l ax3l force-pushed the topic-setupPy branch 5 times, most recently from cff44ae to ac83915 Compare October 4, 2018 06:29
@ax3l ax3l changed the title [WIP] setup.py setup.py for sdist Oct 4, 2018
@ax3l ax3l requested a review from C0nsultant October 4, 2018 06:32
@ax3l ax3l added the continuous deployment automated shipping label Oct 4, 2018
I am not sure it it does more harm than good to expose this to the
user or if I should hide a perfectly tailored, `PyPI` distribution
building only one deep in the source tree.
@ax3l ax3l merged commit 421db0c into openPMD:dev Oct 4, 2018
@ax3l ax3l deleted the topic-setupPy branch October 4, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants