Fix native_libs.txt #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building additional, auxiliary libraries they should receive
proper handling in "native_libs.txt". Surprisingly, this only
happens when a trailing `/` is added.
Also, the primary module will then go into the package directory.
Additional `RPATH`/`RUNPATH` handling for auxiliary, "native" libs
is likely needed. E.g. on Linux/OSX:
```
'-DCMAKE_INSTALL_RPATH=$ORIGIN',
'-DCMAKE_BUILD_WITH_INSTALL_RPATH:BOOL=ON',
'-DCMAKE_INSTALL_RPATH_USE_LINK_PATH:BOOL=OFF',
```
while on Windows one can just keep a flat structure in the package,
which will be in `%PATH%`.
This was referenced Sep 25, 2018
Closed
|
This pull request got no responses? |
|
I know, right? :) ping @dean0x7d and @SylvainCorlay |
|
Sure, sorry about the delay. |
|
No problem, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building additional, auxiliary libraries they should receive proper handling in "native_libs.txt". Surprisingly, this only happens when a trailing
/is added.Also, together with the primary module the (shared) libs will then go into the package directory instead of lying somewhere in the base path.
native_libs.txtalso takes care, that these auxiliary, non-python, "native" libs are properly deinstalled as well.Additional
RPATH/RUNPATHhandling for auxiliary, "native" libs is likely needed. E.g. on Linux when placing them all in the same base path ($ORIGINis not a bash variable) of the package:while on Windows one can just keep a flat structure in the package, which will be in
%PATH%for the primary module and its helper.dlls.Larger project example: openPMD/openPMD-api#240