Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] new UI can be too narrow #6033

Closed
aspiers opened this issue Oct 5, 2018 · 6 comments
Closed

[beta] new UI can be too narrow #6033

aspiers opened this issue Oct 5, 2018 · 6 comments
Assignees
Labels
Bootstrap 🚀 Bootstrap migration Frontend Things related to the OBS RoR app

Comments

@aspiers
Copy link
Member

aspiers commented Oct 5, 2018

Issue Description

Just like with GitHub, enforcing a maximum width on the main content of each page in the layout can cause things to be too squashed and waste a lot of valuable screen space.

How to Reproduce

  1. Join the beta program
  2. Go to https://build.opensuse.org/package/show/systemsmanagement:sumaform:opensuse423/cloud-init
  3. See something like this:

obs-width

  1. Notice how certain lines are needlessly wrapped, and how much wasted space there is.

Expected Result

Tweaking the width gives a much nicer result:

obs-width2

However, everyone's tastes / browsers / displays are different, so this should be adjustable.

@dmarcoux dmarcoux added Frontend Things related to the OBS RoR app Bootstrap 🚀 Bootstrap migration labels Oct 5, 2018
@dmarcoux
Copy link
Contributor

dmarcoux commented Oct 5, 2018

Thank you @aspiers for the feedback. We definitely need to use the space when available.

I'm not sure though about the adjustable width. However, let's say that we want to move forward with this proposal. How would you want to set this? On the user profile page?

@aspiers
Copy link
Member Author

aspiers commented Oct 5, 2018

Ideally it would be settable by dragging the (perhaps invisible) border with the mouse, just like resizing normally happens. Divorcing the setting from the view which it affects will reduce usability IMHO. The way Chrome's inspector handles boundaries is a good example to follow.

@aspiers
Copy link
Member Author

aspiers commented Oct 5, 2018

Also, I guess the setting should be stored in a cookie, so that it is per browser/machine. It wouldn't make sense to have the same setting for a user's laptop and workstation, so per-account doesn't make sense.

@hellcp
Copy link
Member

hellcp commented Oct 6, 2018

I would say that adding one more breakpoint to preset set by bootstrap would be enough (not to break breakpoints set for smaller devices). Currently, default bootstrap breakpoints that are used in OBS are

.container {
 width:100%;
 padding-right:15px;
 padding-left:15px;
 margin-right:auto;
 margin-left:auto
}
@media (min-width: 576px) {
 .container {
  max-width:540px
 }
}
@media (min-width: 768px) {
 .container {
  max-width:720px
 }
}
@media (min-width: 992px) {
 .container {
  max-width:960px
 }
}
@media (min-width: 1200px) {
 .container {
  max-width:1140px
 }
}

adding

@media (min-width: 1600px) {
 .container {
  max-width:1540px
 }
}

would solve the issue for at least 1080p displays at 100% viewpoint width.

@Conan-Kudo
Copy link
Member

I would personally like to see fluid width support as a toggle in the new OBS UI. The amount of wasted space in the UI has always bothered me, and it'd be good if it's possible for it to "flex" if the user asks for it.

@hellcp
Copy link
Member

hellcp commented Nov 21, 2018

Current .card based layout wouldn't work well with fluid container, that will require bigger re 🤔

@bgeuken bgeuken self-assigned this Nov 30, 2018
bgeuken added a commit to bgeuken/open-build-service that referenced this issue Nov 30, 2018
Kudos for providing the breakpoints goes to @hellcp

Fixes openSUSE#6033
bgeuken added a commit to bgeuken/open-build-service that referenced this issue Nov 30, 2018
Kudos for providing the breakpoints goes to @hellcp

Fixes openSUSE#6033
bgeuken added a commit to bgeuken/open-build-service that referenced this issue Dec 2, 2018
The breakpoints that come with bootstrap don't cover screen sizes
above 1200px. Because of that the OBS pages don't use the full width
of the screen.

Fixes openSUSE#6033

Co-authored-by: Stasiek Michalski <hellcp@opensuse.org>
bgeuken added a commit to bgeuken/open-build-service that referenced this issue Dec 2, 2018
The breakpoints that come with bootstrap don't cover screen sizes
above 1200px. Because of that the OBS pages don't use the full width
of the screen.

Fixes openSUSE#6033

Co-authored-by: Stasiek Michalski <hellcp@opensuse.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap 🚀 Bootstrap migration Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

5 participants