Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breakpoint for very larger screens #6416

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Add breakpoint for very larger screens #6416

merged 1 commit into from
Dec 3, 2018

Conversation

bgeuken
Copy link
Member

@bgeuken bgeuken commented Nov 30, 2018

Kudos for providing the breakpoints goes to @hellcp

Fixes #6033

@bgeuken bgeuken added Frontend Things related to the OBS RoR app Bootstrap 🚀 Bootstrap migration labels Nov 30, 2018
Ana06
Ana06 reviewed Nov 30, 2018
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgeuken from your commit:

Kudos for providing the breakpoints goes to @hellcp

What about adding him as co-author? The commit description is to explain why this is needed not who came with the solution, for that you have co-author 😉

@bgeuken @hellcp
Add another breakpoint for screens up to 1600px
dff6448 
The breakpoints that come with bootstrap don't cover screen sizes
above 1200px. Because of that the OBS pages don't use the full width
of the screen.

Fixes openSUSE#6033

Co-authored-by: Stasiek Michalski <hellcp@opensuse.org>
@Ana06 Ana06 merged commit be6b1e0 into openSUSE:master Dec 3, 2018
@hennevogel
Copy link
Member

Did anybody check if this breaks pages? It isn't called breakpoint without a reason 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarcoux dmarcoux dmarcoux left review comments

@Ana06 Ana06 Ana06 approved these changes

Assignees
No one assigned
Labels
Bootstrap 🚀 Bootstrap migration Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgeuken @hennevogel @dmarcoux @Ana06