Comment for isolated migrations #15760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraycp
force-pushed
the
comment_for_isolated_migrations
branch
21 times, most recently
from
1ce5771 to
a7d5d5c
Compare
saraycp
force-pushed
the
comment_for_isolated_migrations
branch
2 times, most recently
from
fde5576 to
a4df352
Compare
They write comments when:
- there is a migration together with other changes (except schema
changes),
- there is a migration but not its corresponding db schema,
- there is a data migration but not its corresponding data schema.
It is splitted into two actions, the first one stores the texts in
artifacts (text files) and the second one create the comments using
those texts. This is required to allow pull requests that come from
forks to write.
saraycp
force-pushed
the
comment_for_isolated_migrations
branch
from
a4df352 to
f8b1418
Compare
|
Closing in favor of: #15824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Isolated Migrations check doesn't cover all the project's necessities:
There is no need to have a check that fails or passes. It is enough with a comment warning about the presence of migrations together with other changes.
With these two new GitHub actions, the PR can get any of the comments in the following image when:
Pull requests that come from a fork don't have write permissions, so we can't write comments to a PR from one single GitHub action. That's why this is split into two actions to make it work and be safe, according to this article.
Moreover, these actions should be in production to work. Otherwise, the second action/workflow will never run.