Refactor the notification toolbar helpers to make them simpler #16594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danidoni
force-pushed
the
fix-the-mark-as-read-or-unread-button-in-notification-toolbar
branch
from
9a4af6f to
6c6141a
Compare
danidoni
force-pushed
the
fix-the-mark-as-read-or-unread-button-in-notification-toolbar
branch
2 times, most recently
from
e048b89 to
2ac36d4
Compare
danidoni
changed the title
Reducing all the helpers conditions to just one and transform the tag building helpers into just view template code makes everything simpler. It does not need testing then.
danidoni
force-pushed
the
fix-the-mark-as-read-or-unread-button-in-notification-toolbar
branch
from
2ac36d4 to
9505839
Compare
saraycp
approved these changes
Aug 1, 2024
danidoni
deleted the
fix-the-mark-as-read-or-unread-button-in-notification-toolbar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16596