Fix mark as read button on the notification bar #16596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraycp
force-pushed
the
fix_mark_as_read
branch
2 times, most recently
from
4b46c05 to
d6ec99f
Compare
|
oops, there is another PR about this #16594 We'll figure out which one we want to leave... |
We were not using the correct param name.
saraycp
force-pushed
the
fix_mark_as_read
branch
from
d6ec99f to
329050b
Compare
|
We're going to keep this PR to fix the error. Then, #16594 will introduce a refactoring to get rid of the helper |
danidoni
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not passing what kind of button we had: "mark as read" or "mark as unread"
Fixes: #16587