Add optional js_repl isolation and vendored Node runtime#10670
Draft
fjord-oai wants to merge 3 commits intofjord/js_repl_seq---4hn_deh_pjc2v_from
Draft
Add optional js_repl isolation and vendored Node runtime#10670fjord-oai wants to merge 3 commits intofjord/js_repl_seq---4hn_deh_pjc2v_from
fjord-oai wants to merge 3 commits intofjord/js_repl_seq---4hn_deh_pjc2v_from
Conversation
This was referenced Feb 4, 2026
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
ba72a13 to
3d292c8
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
3d292c8 to
46cde12
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
46cde12 to
8a2d2d7
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
8a2d2d7 to
3400169
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
3400169 to
8093818
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
8093818 to
7df6e4f
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
7df6e4f to
7484eb0
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
7484eb0 to
030277a
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
030277a to
25dfdc4
Compare
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
0b00f02 to
2e792e5
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
git-stack-id: fjord/js_repl_seq---4hseucc1sxf70k git-stack-title: Stop filtering model tools in js_repl_tools_only mode
git-stack-id: fjord/js_repl_seq---4hn_deh_pjc2v_ git-stack-title: Add feature-gated js_repl polling flow
git-stack-id: fjord/js_repl_seq---4hn_df54gsg6af git-stack-title: Add optional js_repl isolation and vendored Node runtime
fjord-oai
changed the base branch from
fjord/js_repl_seq---4hn_deh_pjc2v_
to
main
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_df54gsg6af
branch
from
2e792e5 to
84432da
Compare
fjord-oai
changed the base branch from
main
to
fjord/js_repl_seq---4hn_deh_pjc2v_
aaronl-openai
pushed a commit
that referenced
this pull request
Feb 18, 2026
## Summary This change removes tool-list filtering in `js_repl_tools_only` mode and relies on the normal model tool descriptions, while still enforcing that tool execution must go through `js_repl` + `codex.tool(...)`. ## Motivation The previous `js_repl_tools_only` filtering hid most tools from the model request, which diverged from standard tool-list behavior and made signatures less discoverable. I tested that this filtering is not needed, and the model can follow the prompt to only call tools via `js_repl`. ## What Changed - `filter_tools_for_model(...)` in `core/src/tools/spec.rs` is now a pass-through (no filtering when `js_repl_tools_only` is enabled). - Updated tests to assert that model tools are not filtered in `js_repl_tools_only` mode. - Updated dynamic-tool test to assert dynamic tools remain visible in model tool specs. - Removed obsolete test helper used only by the old filtering assertions. ## Safety / Behavior - This commit does **not** relax execution policy. - Direct model tool calls remain blocked in `js_repl_tools_only` mode (except internal `js_repl` tools), and callers are instructed to use `js_repl` + `codex.tool(...)`. ## Testing - `cargo test -p codex-core js_repl_tools_only` - Manual rollout validation showed the model can follow the `js_repl` routing instructions without needing filtered tool lists. #### [git stack](https://github.com/magus/git-stack-cli) - 👉 `1` #12069 - ⏳ `2` #10673 - ⏳ `3` #10670
fjord-oai
force-pushed
the
fjord/js_repl_seq---4hn_deh_pjc2v_
branch
19 times, most recently
from
1c662b9 to
5d92d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.
Include a link to a bug report or enhancement request.
git stack
1Add feature-gated freeform js_repl core runtime #106742Add js_repl host helpers and exec end events #106723Add js_repl_tools_only model and routing restrictions #106714Add js_repl kernel crash diagnostics #116665Fix js_repl view_image test runtime panic #117966Fix js_repl in-flight tool-call waiter race #118007Stop filtering model tools in js_repl_tools_only mode #120698Add feature-gated js_repl polling flow #106739Add optional js_repl isolation and vendored Node runtime #10670