Fix js_repl view_image test runtime panic#11796
Merged
Conversation
This was referenced Feb 13, 2026
owenlin0
approved these changes
Feb 13, 2026
e4980ee to
d46df1e
Compare
git-stack-id: fjord/js_repl_seq---4hqupa7505_e7j git-stack-title: Fix js_repl view_image test runtime panic
d46df1e to
f396742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky/panicking
js_replimage-path test by running it on a multi-thread Tokio runtime and tightening assertions to focus on real behavior.Problem
js_repl_can_attach_image_via_view_image_toolin/Users/fjord/code/codex-jsrepl-seq/codex-rs/core/src/tools/js_repl/mod.rscan panic under single-thread test runtime with:
can call blocking only when running on the multi-threaded runtimeIt also asserted a brittle user-facing text string.
Changes
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]"attached local image path"string assertion.InputImagewithdata:image/png;base64,...)Why this is safe
This is test-only behavior. No production runtime code paths are changed.
Validation
cargo test -p codex-core tools::js_repl::tests::js_repl_can_attach_image_via_view_image_tool -- --nocapturegit stack
1Fix js_repl view_image test runtime panic #117962Fix js_repl in-flight tool-call waiter race #118003Add feature-gated js_repl polling flow #106734Add optional js_repl isolation and vendored Node runtime #10670