Skip to content

fix: remove config.schema.json from tag check #10980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bolinfest merged 1 commit into from
Feb 8, 2026
Merged

fix: remove config.schema.json from tag check #10980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/rust-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,6 @@ jobs:
echo "✅ Tag and Cargo.toml agree (${tag_ver})"
echo "::endgroup::"
Comment on lines 45 to 46
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep schema fixture validation in release tags

Removing the config schema verification step in the tag-check job means a release can succeed even if codex-rs/core/config.schema.json is stale. Since this workflow later copies that file into the release artifacts (cp codex-rs/core/config.schema.json dist/config-schema.json around line 478), a tag that updates ConfigToml but forgets to regenerate the schema will now silently publish an outdated schema to users. This regression depends on a config change landing without running just write-config-schema, which the removed guard previously caught.

Useful? React with 👍 / 👎.

- name: Verify config schema fixture
shell: bash
working-directory: codex-rs
run: |
set -euo pipefail
echo "If this fails, run: just write-config-schema to overwrite fixture with intentional changes."
cargo run -p codex-core --bin codex-write-config-schema
git diff --exit-code core/config.schema.json
build:
needs: tag-check
name: Build - ${{ matrix.runner }} - ${{ matrix.target }}
Expand Down
Loading