fix: remove config.schema.json from tag check #10980
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77e6c740e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "✅ Tag and Cargo.toml agree (${tag_ver})" | ||
| echo "::endgroup::" |
There was a problem hiding this comment.
Removing the config schema verification step in the tag-check job means a release can succeed even if codex-rs/core/config.schema.json is stale. Since this workflow later copies that file into the release artifacts (cp codex-rs/core/config.schema.json dist/config-schema.json around line 478), a tag that updates ConfigToml but forgets to regenerate the schema will now silently publish an outdated schema to users. This regression depends on a config change landing without running just write-config-schema, which the removed guard previously caught.
Useful? React with 👍 / 👎.
I did not wait for CI on #10980 because it was blocking an alpha release, but apparently it broken the Windows build.
I did not wait for CI on #10980 because it was blocking an alpha release, but apparently it broken the Windows build.
2 participants
Given that we have #10977, the existing "Verify config schema fixture" step seems unnecessary. Further, because it happens as part of the
tag-checkjob (which is meant to be fast), it slows down the entire build process because it delays the more expensive steps from starting.