Revert "Add app-server transport layer with websocket support (#10693)"#11323
Revert "Add app-server transport layer with websocket support (#10693)"#11323
Conversation
…j/revert-8473096e
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19f3f811a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Wait for all tasks to finish. The typical exit path is the stdin reader | ||
| // hitting EOF which, once it drops `incoming_tx`, propagates shutdown to | ||
| // the processor and then to the stdout task. | ||
| let _ = tokio::join!(stdin_reader_handle, processor_handle, stdout_writer_handle); |
There was a problem hiding this comment.
run_main now blocks on stdout_writer_handle, but that task only exits when outgoing_rx is closed; meanwhile several CodexMessageProcessor paths spawn background work (for example command/exec and login/OAuth flows) that clone OutgoingMessageSender. If a client closes stdin (EOF) while those jobs are still running, the processor exits but those clones keep the channel alive, so stdout_writer_handle can wait indefinitely and process shutdown hangs even though input is gone.
Useful? React with 👍 / 👎.
3 participants
Suspected cause of deadlocking bug