js_repl: canonicalize paths for node_modules boundary checks#12177
Merged
js_repl: canonicalize paths for node_modules boundary checks#12177
Conversation
git-stack-id: fjord/js_repl_seq---4hspua2-8n4nq5 git-stack-title: js_repl: canonicalize paths for node_modules boundary checks
aaronl-openai
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
js_replpackage-resolution boundary checks for macOS temp directory path aliasing (/varvs/private/var).Problem
js_replverifies that resolved bare-package imports stay inside a configurednode_modulesroot.On macOS, temp directories are commonly exposed as
/var/...but canonicalize to/private/var/....Because the boundary check compared raw paths with
path.relative(...), valid resolutions under temp dirs could be misclassified as escaping the allowed base, causing falseModule not founderrors.Changes
fsimport in the JS kernel.canonicalizePath()usingfs.realpathSync.native(...)(with safe fallback).baseandresolvedPathbefore running thenode_modulescontainment check.Impact
js_replkernel module path validation logic.git stack
1js_repl: canonicalize paths for node_modules boundary checks #121772Add feature-gated js_repl polling flow #10673