Skip to content

js_repl: canonicalize paths for node_modules boundary checks #12177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjord-oai merged 1 commit into from
Feb 18, 2026
+13 −2
Merged

js_repl: canonicalize paths for node_modules boundary checks #12177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions codex-rs/core/src/tools/js_repl/kernel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

const { Buffer } = require("node:buffer");
const crypto = require("node:crypto");
const fs = require("node:fs");
const { builtinModules, createRequire } = require("node:module");
const { createInterface } = require("node:readline");
const { performance } = require("node:perf_hooks");
Expand Down Expand Up @@ -149,6 +150,14 @@ const moduleSearchBases = (() => {
const importResolveConditions = new Set(["node", "import"]);
const requireByBase = new Map();

function canonicalizePath(value) {
try {
return fs.realpathSync.native(value);
} catch {
return value;
}
}

function getRequireForBase(base) {
let req = requireByBase.get(base);
if (!req) {
Expand All @@ -165,8 +174,10 @@ function isModuleNotFoundError(err) {
}

function isWithinBaseNodeModules(base, resolvedPath) {
const nodeModulesRoot = path.resolve(base, "node_modules");
const relative = path.relative(nodeModulesRoot, resolvedPath);
const canonicalBase = canonicalizePath(base);
const canonicalResolved = canonicalizePath(resolvedPath);
const nodeModulesRoot = path.resolve(canonicalBase, "node_modules");
const relative = path.relative(nodeModulesRoot, canonicalResolved);
return (
relative !== "" && !relative.startsWith("..") && !path.isAbsolute(relative)
);
Expand Down
Loading