Skip to content

Fix rmcp client feature flag reference #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

Fix rmcp client feature flag reference #6051

merged 1 commit into from
Nov 3, 2025

Conversation

@nornagon-openai
Copy link
Collaborator

@nornagon-openai nornagon-openai commented Oct 31, 2025

Summary

  • update the OAuth login error message to reference [features].rmcp_client in config

Testing

  • cargo test -p codex-cli

https://chatgpt.com/codex/tasks/task_i_69050365dc84832ca298f863c879a59a

gpeal
gpeal approved these changes Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even correct? What about people who set experimental_use_rmcp_client?

cc @jif-oai

@etraut-openai etraut-openai added the oai-pr PRs posted by Codex team members label Oct 31, 2025
@nornagon-openai nornagon-openai merged commit 7bc3ca9 into main Nov 3, 2025
25 checks passed
@nornagon-openai nornagon-openai deleted the nornagon/codex/fix-feature-name-in-message branch November 3, 2025 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gpeal gpeal gpeal approved these changes

Assignees

No one assigned

Labels

codex oai-pr PRs posted by Codex team members

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nornagon-openai @gpeal @etraut-openai