Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tasks to use the new Powershell3 handler and VSTS task SDK. #29

Open
harshil93 opened this issue Apr 19, 2016 · 7 comments
Open

Port tasks to use the new Powershell3 handler and VSTS task SDK. #29

harshil93 opened this issue Apr 19, 2016 · 7 comments

Comments

@harshil93
Copy link
Member

harshil93 commented Apr 19, 2016

We need to use the new VSTS Task SDK

It will allow for better testability with actually using the agent and better tracing.

The plan for doing this is to have both the handlers co-exist for compat issues and then we can delete the Powershell handler later.

@pascalberger
Copy link
Contributor

@harshil93 Any progress on this? I see there exists a branch here but no commits there since two months.

@harshil93
Copy link
Member Author

@pascalberger I will try to get this merged when I get some time off, may be this weekend.

@harshil93
Copy link
Member Author

@pascalberger Hey can you help me in testing this. #50 I have raised the PR but wanted someone who is actively using it to test it. You can install it using tfx-cli

@pascalberger
Copy link
Contributor

@harshil93 Unfortunately I don't have any definitions using this task. I always wanted to use it but #24 is a blocking issue for me.

@harshil93
Copy link
Member Author

Thanks, I will try to complete my testing and will try to get it merged asap.

via CloudMagic Emailhttps://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.5.49&pv=6.0.1&source=email_footer_2
On Sun, Jul 24, 2016 at 11:23 PM, Pascal Berger <notifications@github.commailto:notifications@github.com> wrote:

@harshil93https://github.com/harshil93 Unfortunately I don't have any definitions using this task. I always wanted to use it but #24#24 is a blocking issue for me.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/29#issuecomment-234791431, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABH30jJAxza8F_M2dla9hd12Ip36Sq29ks5qY6Z9gaJpZM4IKrs5.

@incarnate
Copy link
Contributor

I've just tested this in my VSTS account with a clone of an existing build workflow which uses Tokenizer currently - it worked as expected.

The only thing missing is this change so that the task shows up for Build definitions as well as Releases.

Thanks!

@PaulMEdwards
Copy link

Thanks for all of your efforts.
Has this been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants