-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/vsts new sdk port #50
Conversation
@harshil93 Shouldn't the old PS handler be removed? Or do you plan to maintain two versions. Sounds like too much trouble to me to keep them in sync. |
I will remove it after a month or so if no issues came up. People using TFS update 2 might not have the latest handler. via CloudMagic Emailhttps://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.5.49&pv=6.0.1&source=email_footer_2 @harshil93https://github.com/harshil93 Shouldn't the old PS handler be removed? Or do you plan to maintain two versions. Sounds like too much trouble to me to keep them in sync. You are receiving this because you were mentioned. |
@harshil93 Any plans to merge this soon, as I'm waiting for this to fix #24? |
[string]$DestinationPath = Get-VstsInput -Name DestinationPath | ||
[string]$ConfigurationJsonFile = Get-VstsInput -Name ConfigurationJsonFile | ||
. $PSScriptRoot\Helpers.ps1 | ||
Write-Verbose "Entering script tokenize.ps1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be redundant to the Trace-VstsEnterinigInvocation call above. Also the output of the parameters
Porting the the task to use the new sdk and adding some tests