Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/vsts new sdk port #50

Merged
merged 5 commits into from
Aug 31, 2016
Merged

Features/vsts new sdk port #50

merged 5 commits into from
Aug 31, 2016

Conversation

harshil93
Copy link
Member

Porting the the task to use the new sdk and adding some tests

@pascalberger
Copy link
Contributor

@harshil93 Shouldn't the old PS handler be removed? Or do you plan to maintain two versions. Sounds like too much trouble to me to keep them in sync.

@harshil93
Copy link
Member Author

I will remove it after a month or so if no issues came up. People using TFS update 2 might not have the latest handler.

via CloudMagic Emailhttps://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.5.49&pv=6.0.1&source=email_footer_2
On Sun, Jul 24, 2016 at 11:11 PM, Pascal Berger <notifications@github.commailto:notifications@github.com> wrote:

@harshil93https://github.com/harshil93 Shouldn't the old PS handler be removed? Or do you plan to maintain two versions. Sounds like too much trouble to me to keep them in sync.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/50#issuecomment-234790843, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABH30m-J5Adup4EAEr5cVYNQkU78tNfxks5qY6PhgaJpZM4JTnpv.

@pascalberger
Copy link
Contributor

@harshil93 Any plans to merge this soon, as I'm waiting for this to fix #24?

[string]$DestinationPath = Get-VstsInput -Name DestinationPath
[string]$ConfigurationJsonFile = Get-VstsInput -Name ConfigurationJsonFile
. $PSScriptRoot\Helpers.ps1
Write-Verbose "Entering script tokenize.ps1"
Copy link
Contributor

@pascalberger pascalberger Aug 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be redundant to the Trace-VstsEnterinigInvocation call above. Also the output of the parameters

@harshil93 harshil93 merged commit 3fee67c into master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants