-
-
Notifications
You must be signed in to change notification settings - Fork 228
The requestBody declared with $ref is not generating json_body #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi I just submitted a PR above which works with your yaml. It'll be helpful if you have some time to review Outputdef sync_detailed(
*,
client: Client,
json_body: Object,
) -> Response[Object]:
"""
Args:
json_body (Object):
Returns:
Response[Object]
"""
kwargs = _get_kwargs(
client=client,
json_body=json_body,
)
response = httpx.request(
verify=client.verify_ssl,
**kwargs,
)
return _build_response(response=response)
async def asyncio_detailed(
*,
client: Client,
json_body: Object,
) -> Response[Object]:
"""
Args:
json_body (Object):
Returns:
Response[Object]
"""
kwargs = _get_kwargs(
client=client,
json_body=json_body,
)
async with httpx.AsyncClient(verify=client.verify_ssl) as _client:
response = await _client.request(**kwargs)
return _build_response(response=response) |
hello, do you have an update on the ongoing PR? I'm facing the exact same issue :/ |
@Leemur89 This library seems not actively maintained. I recommend just using the official openapi generator |
@kigawas are you sure? It just got a new release last week |
3.1 support is in progress in #856 . I would categorize this project as "lightly maintained", I am still working on it but it's (mostly) only me and it's not my focus. |
@dbanty Glad to hear you are working on this! |
This PR was created by Knope. Merging it will create a new release ### Features #### Support request body refs You can now define and reuse bodies via refs, with a document like this: ```yaml paths: /something: post: requestBody: "$ref": "#/components/requestBodies/SharedBody" components: requestBodies: SharedBody: content: application/json: schema: type: string ``` Thanks to @kigawas and @supermihi for initial implementations and @RockyMM for the initial request. Closes #633, closes #664, resolves #595. ### Fixes - Indent of generated code for non-required lists. Thanks @sfowl! (#1050) - Parsing requestBody with $ref (#633) Co-authored-by: GitHub <github-actions@github.com>
Fixes openapi-generators#595 Perhaps similar solution can be applied to openapi-generators#605 ## Description The requestBody with $ref was not handled. `requestBodies` in components should be injected into `_add_body` function. --------- Co-authored-by: Dylan Anthony <dbanty@users.noreply.github.com>
This PR was created by Knope. Merging it will create a new release ### Features #### Support request body refs You can now define and reuse bodies via refs, with a document like this: ```yaml paths: /something: post: requestBody: "$ref": "#/components/requestBodies/SharedBody" components: requestBodies: SharedBody: content: application/json: schema: type: string ``` Thanks to @kigawas and @supermihi for initial implementations and @RockyMM for the initial request. Closes openapi-generators#633, closes openapi-generators#664, resolves openapi-generators#595. ### Fixes - Indent of generated code for non-required lists. Thanks @sfowl! (openapi-generators#1050) - Parsing requestBody with $ref (openapi-generators#633) Co-authored-by: GitHub <github-actions@github.com>
Describe the bug
If a
requestBody
is declared with a$ref
, then nojson_body
property is generated. If the reference is inlined, thenjson_body
is generated.To Reproduce
Steps to reproduce the behaviour:
Expected behavior
The expected API should be:
OpenAPI Spec File
test.yaml
The text was updated successfully, but these errors were encountered: