Support request bodies components #664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note – I probably won't have time to continue this for the next few weeks, would be happy if s/o else could pick up :) |
supermihi
force-pushed
the
support-request-bodies-components
branch
from
22fceac to
c730b9f
Compare
supermihi
force-pushed
the
support-request-bodies-components
branch
from
c730b9f to
87969ab
Compare
|
@dbanty I think it's complete now, would you mind to take a look? Disclaimer: I fixed the existing unit tests but did not write new ones especially for the new fetaure. To be honest I didn't really understand what how the tests work and what they actually test. ;-) |
supermihi
changed the title
ghost
mentioned this pull request
|
Thank you for doing this, and sorry it took so long for me to get around to it. I ended up updating the other PR and finishing off, since there are soo many merge conflicts now (due to my delay). |
dbanty
added a commit
that referenced
this pull request
Jun 15, 2024
This PR was created by Knope. Merging it will create a new release
### Features
#### Support request body refs
You can now define and reuse bodies via refs, with a document like this:
```yaml
paths:
/something:
post:
requestBody:
"$ref": "#/components/requestBodies/SharedBody"
components:
requestBodies:
SharedBody:
content:
application/json:
schema:
type: string
```
Thanks to @kigawas and @supermihi for initial implementations and
@RockyMM for the initial request.
Closes #633, closes #664, resolves #595.
### Fixes
- Indent of generated code for non-required lists. Thanks @sfowl!
(#1050)
- Parsing requestBody with $ref (#633)
Co-authored-by: GitHub <github-actions@github.com>
micha91
pushed a commit
to micha91/openapi-python-client
that referenced
this pull request
May 13, 2025
This PR was created by Knope. Merging it will create a new release
### Features
#### Support request body refs
You can now define and reuse bodies via refs, with a document like this:
```yaml
paths:
/something:
post:
requestBody:
"$ref": "#/components/requestBodies/SharedBody"
components:
requestBodies:
SharedBody:
content:
application/json:
schema:
type: string
```
Thanks to @kigawas and @supermihi for initial implementations and
@RockyMM for the initial request.
Closes openapi-generators#633, closes openapi-generators#664, resolves openapi-generators#595.
### Fixes
- Indent of generated code for non-required lists. Thanks @sfowl!
(openapi-generators#1050)
- Parsing requestBody with $ref (openapi-generators#633)
Co-authored-by: GitHub <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for request bodies referencing to
components/requestBodies/<name>(see spec)Fixes #595. Sorry I only found #633 after preparing this PR, but in contrast to #633 this one also updates tests (including e2e).