-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SMB when BG greater than specified value #1365
Conversation
Still need to implement UTs, but this is an initial commit to get eyes on and daytime testing.
Also move the enableSMB_always at the end as it originally was
Fix profile variable name for high bg target
Similar discussions are now in the Loop community, see LoopKit/Loop#1283 . Hope we find the best way that works for all T1D. Not using oref0 at this moment, so can't participate in the oref0 testing. |
Thanks @stevebell117 looks good to me. I've tried this code out today, since I'd like to limit SMB to be active only when high and this seems to do the trick. I set enableSMB_high_bg = true at 14:30 this afternoon, this is the first time it's been activated. Going forward i'll be using it at a higher threshold, but nice to have the option.
|
Update. I've been using this for the past 10 days and has worked well, no issues that I've found. From a few minutes ago following lunch, High BG enables SMB before minGuardBG disabled it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully with and without the new preference, and above and below current bg.
Just to double check before I volunteer to help with documentation, has the documentation been added for this? I checked these two pages, but didn't see anything related to the new options in this PR. https://openaps.readthedocs.io/en/latest/docs/Customize-Iterate/oref1.html |
This is the result of Issue #1353, and would love to see this implemented as it gives a bit more configuration to users who may want SMBs to be enabled over a certain threshold value. I have been running this on AndroidAPS for nearly 6 months now, and think it would be beneficial for some users. If this is approved, I can also work on updating the documentation to explain what this feature does.
Feature: Enable SMB when a BG is greater than a specified value (high_bg). Let's say a user wants SMBs when their sugars exceed 150mg, with this toggle they can enable SMBs (while obeying the Temp Targeting rules already in place) automatically without having to manually intervene themselves. If a user is sitting below 150mg, then basals would be the only way insulin would be delivered, unless some other SMB rule is satisfied.
Please let me know any concerns/ feedback and I'll do my best to address them!