-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxDelta bg % threshold as hidden preference #1382
Conversation
calculate effective temp basal rate for Omnipod Loop (openaps#1364)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d want to add some bounds checks for this: it’s unsafe to set this much above 0.2.
@scottleibrand Thanks, I've updated the code to set 0.2 as default and 0.3 as a cap. I think this along with PR #1365 will help limit the SMB whilst BGs are low or jumping up from a compression low but also capture the requirement for SMB when BGs rapidly rise following fast acting carbs. Having looked out our recent data I can see BG % moves regularly hit 22%, but we have a lot less 30% moves these days, possibly due to better experience of the system/tuning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment comment. Otherwise LGTM.
lib/profile/index.js
Outdated
@@ -51,6 +51,7 @@ function defaults ( ) { | |||
, maxUAMSMBBasalMinutes: 30 // maximum minutes of basal that can be delivered as a single SMB when IOB exceeds COB | |||
, SMBInterval: 3 // minimum interval between SMBs, in minutes. | |||
, bolus_increment: 0.1 // minimum bolus that can be delivered as an SMB | |||
, maxDelta_bg_threshold: 0.2 // maximum % change in bg to use SMB, above that will disable SMB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a multiple, not a percent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, have removed the %.
maxDelta bg % threshold as hidden preference (openaps#1382)
As per @tynbendad #1278 (comment), we also run into this issue regularly with fast carbs and bgs < 6 mmol/L.
So added a hidden optional % threshold to disable SMB.
Tried this out for the past 24hrs and works as normal at 20%, RigToo running updated % threshold, MealsDev2 running Dev.
Then changed the threshold to 10% in preferences on RigToo and got the following result post lunch.