Add internal identifier for subtitle cues #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subtitle editor requires unique identifiers to work properly. However, the webvtt parser does not provide such ids. WebVTT cue ids are not a good fit either, as they hardly qualifiy as identifiers. This adds a new field to the subtitle cues to act as a unique identifier. This should also stop the editor from adding randomly generated WebVTT cue ids to subtitle files.
|
This pull request is deployed at test.editor.opencast.org/974/2023-02-02_15-07-39/ . |
|
@lkiesow You said you wanted to do reviews, how about this one? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subtitle editor requires unique identifiers to work properly. However, the webvtt parser does not provide such ids. WebVTT cue ids are not a good fit either, as they hardly qualifiy as identifiers.
This adds a new field to the subtitle cues to act as a unique identifier. This should also stop the editor from adding randomly generated WebVTT cue ids to subtitle files.
Helps with #941.