Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error State is not shown in login page #408

Open
antonioaltamura opened this issue Feb 15, 2022 · 2 comments
Open

Error State is not shown in login page #408

antonioaltamura opened this issue Feb 15, 2022 · 2 comments
Assignees
@antonioaltamura
Labels
bug

Comments

@antonioaltamura
Copy link
Contributor

The error message is supposed to be shown as a notification and also below the form. Due to the latest changes, the latter is not shown anymore.
IVA-v2-2-0-dev_login
@antonioaltamura antonioaltamura self-assigned this Feb 15, 2022
antonioaltamura added a commit that referenced this issue Feb 15, 2022
@antonioaltamura
wc: errorState correctly show in login page #408
158b7ae
@antonioaltamura
Copy link
Contributor Author

Fixed
IVA-v2-2-0-dev_login

@imedina
Copy link
Member

imedina commented Feb 16, 2022

@antonioaltamura I'm afraid I disagree with this, notifications are now handled by the main application not the basic components. These must just notify, so we do not need the notification at the bottom anymore.

Is this fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonioaltamura antonioaltamura

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imedina @antonioaltamura