Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CellBase url hardcoded at jsorolla #438

Open
pamag opened this issue Mar 16, 2022 · 1 comment
Open

CellBase url hardcoded at jsorolla #438

pamag opened this issue Mar 16, 2022 · 1 comment
Assignees
Labels

Comments

@pamag
Copy link
Member

pamag commented Mar 16, 2022

Describe the bug

There is a CellBase url hardcoded at jsorolla. This is problematic with some clients that use IVA through VPN and have their own CellBase an almost all network connection blocked to outside sites. So this hardcoded url is a big problem.

https://github.com/opencb/jsorolla/blob/release-2.2.x/src/webcomponents/variant/interpretation/variant-interpreter-grid.js#L78

   // FIXME Temporary fix in IVA, THIS MUST BE FIXED IN CELLBASE ASAP!
        this.cellbaseClient = new CellBaseClient({
            host: "https://ws.zettagenomics.com/cellbase",
            version: "v5",
            species: "hsapiens"
        })

variant-interpreter-grid.js

        this.cellbaseClient = new CellBaseClient({

There is a call in this line
https://github.com/opencb/jsorolla/blob/release-2.2.x/src/webcomponents/variant/interpretation/variant-interpreter-grid.js#L310 con cellbaseClient.
variant-interpreter-grid.js

                                this.cellbaseClient.get("feature", "gene", geneNamesString, "info", {
@pamag pamag added the bug label Mar 16, 2022
antonioaltamura added a commit to antonioaltamura/jsorolla that referenced this issue Apr 5, 2022
@imedina imedina self-assigned this Apr 7, 2022
@imedina
Copy link
Member

imedina commented Apr 7, 2022

@pamag I have removed the code in 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants