Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time features to multimodal.py #240

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add time features to multimodal.py #240

merged 2 commits into from
Aug 6, 2024

Conversation

AUdaltsova
Copy link
Contributor

Pull Request

Description

Sister PR to ocf_datapipes PR 347

Adding optional layers to multimodal for sine and cosine of time of year, time of day (total 4 features) calculated in datapipes

How Has This Been Tested?

Ran training of windnet with time features included

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Sukh-P
Sukh-P approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AUdaltsova AUdaltsova merged commit bde05e2 into main Aug 6, 2024
3 checks passed
@AUdaltsova AUdaltsova deleted the trigonometric_time branch August 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AUdaltsova @Sukh-P