Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include trigonometric time features #347

Merged
merged 18 commits into from
Aug 6, 2024
Merged

Include trigonometric time features #347

merged 18 commits into from
Aug 6, 2024

Conversation

AUdaltsova
Copy link
Contributor

@AUdaltsova AUdaltsova commented Jul 26, 2024 •
edited
Loading

Pull Request

Description

Adding calculation and support for trigonometric time features (sine and cosine of time of year and time of day, 4 features total) for windnet. Currently calculated only from windnet based on wind's time index

NB: it replaces add_sun_position at MergeNumpyModalities in windnet.py; ultimately decided it's never used for wind, so not a loss.

Added tests to check time transform works as expected

How Has This Been Tested?

Ran training of windnet with time features included

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova AUdaltsova mentioned this pull request Jul 26, 2024
Merged
6 tasks
@AUdaltsova AUdaltsova requested a review from Sukh-P August 5, 2024 17:01
@AUdaltsova AUdaltsova marked this pull request as ready for review August 6, 2024 09:34
@peterdudfield
Copy link
Contributor

does the PR description need an update?

Sukh-P
Sukh-P approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work adding this in!

@AUdaltsova
Copy link
Contributor Author

Ok I think this is good to go, if @peterdudfield @Sukh-P you're both happy I'll merge?

@AUdaltsova AUdaltsova merged commit 3b7f5a6 into main Aug 6, 2024
3 checks passed
@AUdaltsova AUdaltsova deleted the trigonometric_time branch August 6, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AUdaltsova @peterdudfield @Sukh-P