-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include trigonometric time features #347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
6 tasks
Sukh-P
reviewed
Aug 5, 2024
Sukh-P
reviewed
Aug 6, 2024
Sukh-P
reviewed
Aug 6, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
does the PR description need an update? |
Sukh-P
reviewed
Aug 6, 2024
Sukh-P
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work adding this in!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Ok I think this is good to go, if @peterdudfield @Sukh-P you're both happy I'll merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding calculation and support for trigonometric time features (sine and cosine of time of year and time of day, 4 features total) for windnet. Currently calculated only from windnet based on wind's time index
NB: it replaces add_sun_position at
MergeNumpyModalities
inwindnet.py
; ultimately decided it's never used for wind, so not a loss.Added tests to check time transform works as expected
How Has This Been Tested?
Ran training of windnet with time features included
Checklist: