[OC-93] - Send supported templates as http header

[nickbalestra]

Context: this will allow for example for React SSR to delegate to the Registry for the rendering, in case the template is not supported by the client.

https://opentable.atlassian.net/browse/OC-93

[nickbalestra]

To check for the warmup/init - it seems to me that we don't do any options sanitizing (neither here or here - only config sanit here.

@mattiaerre I want therefore to add options sanitization within the warmup as well, what you think?

[mattiaerre]

over to you @nickbalestra

[mattiaerre]

me ❤️ this

[mattiaerre]

I'd love to avoid param reassign; shall we Object.assign({}, options)?

[mattiaerre]

I was thinking more about something like this:

const sanitiseDefaultOptions = (options, config) => {
  let copy = Object.assign({}, options);
  if (_.isFunction(copy)) {
    copy = {};
  }

  copy.headers = lowerHeaderKeys(copy.headers);
  copy.headers['user-agent'] =
    copy.headers['user-agent'] || getDefaultUserAgent();
  copy.headers.templates =
    copy.headers.templates || getTemplatesInfo(config.templates);

  copy.timeout = copy.timeout || 5;
  return copy;
};

[mattiaerre]

It'd be nice to have a test that covers the uniq method 😉

[nickbalestra]

Totally agree, btw I've added coverage for the uniq helper but we don't have any test at all for all the rest of the utils, to be address in an had hoc PR.

[mattiaerre]

added another comment for you @nickbalestra

[mattiaerre]

I was thinking more about something like this:

const sanitiseDefaultOptions = (options, config) => {
  let copy = Object.assign({}, options);
  if (_.isFunction(copy)) {
    copy = {};
  }

  copy.headers = lowerHeaderKeys(copy.headers);
  copy.headers['user-agent'] =
    copy.headers['user-agent'] || getDefaultUserAgent();
  copy.headers.templates =
    copy.headers.templates || getTemplatesInfo(config.templates);

  copy.timeout = copy.timeout || 5;
  return copy;
};

[nickbalestra]

@mattiaerre yes, much better so

[mattiaerre]

this LGTM I also added some additional comments for you @nickbalestra but very minor stuff. you can automerge if you like 😉

[mattiaerre]

this should be part of the "copy" path as we are changing input if we do that,
but we can iterate later

[mattiaerre]

what about this alternative solution?

const uniq = (input) => {
  const obj = input.reduce((accumulator, element) => {
    const copy = Object.assign({}, accumulator);
    copy[element] = element;
    return copy;
  }, {});

  return Object.keys(obj).map(key => obj[key]);
};

[nickbalestra]

Imho there is no point in copying the accumulator each time.
But the Object.keys works, I'll take that :)

[nickbalestra]

@mattiaerre everything should be addresses

[mattiaerre]

very good thanks for that @nickbalestra

[mattiaerre]

the nice side effect is that is is also "sorting" 😊