[OC-102] Return rendered version if client doesn't support #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaerre
reviewed
Aug 15, 2017
| } | ||
|
|
||
| // Support legacy templates | ||
| let templateType = component.oc.files.template.type; |
Member
There was a problem hiding this comment.
at this point, we are positive that component.oc.files.template is not undefined right?
| }); | ||
| }); | ||
|
|
||
| describe("when oc-client request an unrendered component and it doesn't support the correct template", () => { |
Member
There was a problem hiding this comment.
very minor but I would still use single quotes and either escape the apostrophe w/ a '' or even consider to use '`' instead.
also the describe should be when oc-client requests ...
Contributor
Author
|
@mattiaerre fixed |
mattiaerre
approved these changes
Aug 16, 2017
Member
mattiaerre
left a comment
mattiaerre
left a comment
There was a problem hiding this comment.
this LGTM shall I merge or wait until is [Unblocked]?
Contributor
Author
|
Yes lets wait till we publish the client first as we need to update the client dependency in OC too for this to work correctly |
added 4 commits
August 17, 2017 15:34
nickbalestra
changed the title
ghost
mentioned this pull request
This was referenced Jan 7, 2020
This was referenced Jan 15, 2020
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to (and blocked by)
Registry will handle server side rendering in case of oc-client requesting the unrendered version of an unsupported template