Node 7 #362
Merged
Node 7 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think the main issue is node 7 comes with npm 4, where there is a breaking change that is breaking the tests (dep not found): So I guess I'll try to rework the npm shrinkwrap in order to work with npm 4 /cc @nickbalestra |
|
All green, to you @nickbalestra for reviewing and merging. Not sure reviewing the shrinkwrap is the most exciting task in the planet. I guess you can just see that with no code changes node 7 gets green 🤣 So, basically, trust me, it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a test for now, definitely worth keeping an eye on it and integrating as soon as it gets green