-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… #1514
Merged
richardyu-ms
merged 2 commits into
opencomputeproject:master
from
chrispsommers:add-gensairpc-flags
Jul 26, 2022
Merged
Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… #1514
richardyu-ms
merged 2 commits into
opencomputeproject:master
from
chrispsommers:add-gensairpc-flags
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com>
…file or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com>
chrispsommers
force-pushed
the
add-gensairpc-flags
branch
from
June 25, 2022 18:27
110c976
to
ee64e6f
Compare
chrispsommers
added a commit
to chrispsommers/DASH
that referenced
this pull request
Jun 25, 2022
…to merge eventually. Meanwhile can locally modify SAI makefiles.
@vmytnykx Please look into this and add your comments. Thanks. |
vmytnykx
approved these changes
Jun 27, 2022
kcudnik
approved these changes
Jun 27, 2022
chrispsommers
added a commit
to chrispsommers/DASH
that referenced
this pull request
Jul 6, 2022
…eproject/SAI#1514. Once merged, we can change back to upstream branch of SAI.
This was referenced Jul 11, 2022
chrispsommers
added a commit
to sonic-net/DASH
that referenced
this pull request
Jul 21, 2022
* Build sai-thrift server (not working yet). New dockerfile. * Removed extraneous step. * README * Move Dockerfile under dockerfiles/ * Pass flags to saithrift-build, expecting opencomputeproject/SAI#1514 to merge eventually. Meanwhile can locally modify SAI makefiles. * Fix CI files for new location of Docekrfile.bmv2, add CI for dash-saithrift docker. * Fix CI workflow for new dockerfiles. * Add line to trigger CI. * Restore CI filename, try to get it to trigger. * Rename CI file; modify DOckerfile to trigger; add docker targets to Makefile. * Modify dockerfiles to trigger CI. * Fix make target names in CI and Makefile * Update CI to trigger on CI file changes itself. * Trigger on CI file change. * Remove thrift source from dash-saithrift-bldr docker image. New tag 220625. * Enhance saithrift docker to handle dash sai header generation and libsai compilation. * Remove thrift source and source tarball from docker image; copy python dist tarball to /usr/lib inside container so can be extracted for deployment to a host. * Experimenting with reduced Dockerfiles. * Makefile: p4 source dependencies. dash_pipeline.p4: egress_spec=ingress_spec, comments. * Fix stray merge conflict. * Fix merge conflict in CI file. * Optimized docker build and run images by creating a dedicated gRPC library image and selectively copying to BMV2 builder/runtime image based on available p4lang docker image. * FIx CI, Makefile for new docker images. * Optimize dockerfiles, reduced to 3 images totalling ~2.7G, down from ~10G. * Fix CI files, add Make targets; cleanup. * CI files, badge * CI files. * Split up READMEs into smaller files. Diagram. * READMEs, diagram, SHA version of p4c * Add missing CI workflow (p4c); update main CI workflow to trigger on any dockerfile change. * Fix make command in CI file. * Pin the SHA version of p4lang/behavioral-model:latest. * Ping SHA versions of Ubuntu used in base images. * READMEs - workflows etc. * README typos, clarifications. * README * Use dev fork of SAI which passes flags to gensairpc.pl per opencomputeproject/SAI#1514. Once merged, we can change back to upstream branch of SAI. * Use fork of SAI with fixes for sairpcgen Make flags, and sairpcgen templates which add static_cast to avoid type mismatches due to sai extensions. * Add placeholder code for SAI fixed functions, -fpermissive to avoid enum Long error. TODO: P4RT libs missing, otherwise sai-thrift server builds. * Created init_switch test program and make target to initialize bmv2 model (P4RUntime SetForwardingPipelineRequest) to allow explicit switch intialization via P4Runtime. Removed sudo from most Make commands. READMEs. * Remove dependency to avoid rebuilding files while running test in CI. Delete stray file. * README * Restore dash_pipeline.p4 to same as upstream. Had temporary changes (egress port = ingress port; comments). * Add CI triggers for all .py, .sh, .yml and requirements.txt. under test/ dir * Update to snappi-0.7.38 for fix #153 * Temporary workaround for container permissions issues per #143. Executes chmod as required. Permanent fix will require some Docker mods. * Delete obxolete README, comment out WIP sai-thrift server make targets Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
vmytnykx
pushed a commit
to reshmaintel/SAI
that referenced
this pull request
Aug 2, 2022
opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
KrisNey-MSFT
pushed a commit
to sonic-net/DASH
that referenced
this pull request
Aug 2, 2022
…164) * Build sai-thrift server (not working yet). New dockerfile. * Removed extraneous step. * README * Move Dockerfile under dockerfiles/ * Pass flags to saithrift-build, expecting opencomputeproject/SAI#1514 to merge eventually. Meanwhile can locally modify SAI makefiles. * Fix CI files for new location of Docekrfile.bmv2, add CI for dash-saithrift docker. * Fix CI workflow for new dockerfiles. * Add line to trigger CI. * Restore CI filename, try to get it to trigger. * Rename CI file; modify DOckerfile to trigger; add docker targets to Makefile. * Modify dockerfiles to trigger CI. * Fix make target names in CI and Makefile * Update CI to trigger on CI file changes itself. * Trigger on CI file change. * Remove thrift source from dash-saithrift-bldr docker image. New tag 220625. * Enhance saithrift docker to handle dash sai header generation and libsai compilation. * Remove thrift source and source tarball from docker image; copy python dist tarball to /usr/lib inside container so can be extracted for deployment to a host. * Experimenting with reduced Dockerfiles. * Makefile: p4 source dependencies. dash_pipeline.p4: egress_spec=ingress_spec, comments. * Fix stray merge conflict. * Fix merge conflict in CI file. * Optimized docker build and run images by creating a dedicated gRPC library image and selectively copying to BMV2 builder/runtime image based on available p4lang docker image. * FIx CI, Makefile for new docker images. * Optimize dockerfiles, reduced to 3 images totalling ~2.7G, down from ~10G. * Fix CI files, add Make targets; cleanup. * CI files, badge * CI files. * Split up READMEs into smaller files. Diagram. * READMEs, diagram, SHA version of p4c * Add missing CI workflow (p4c); update main CI workflow to trigger on any dockerfile change. * Fix make command in CI file. * Pin the SHA version of p4lang/behavioral-model:latest. * Ping SHA versions of Ubuntu used in base images. * READMEs - workflows etc. * README typos, clarifications. * README * Use dev fork of SAI which passes flags to gensairpc.pl per opencomputeproject/SAI#1514. Once merged, we can change back to upstream branch of SAI. * Use fork of SAI with fixes for sairpcgen Make flags, and sairpcgen templates which add static_cast to avoid type mismatches due to sai extensions. * Add placeholder code for SAI fixed functions, -fpermissive to avoid enum Long error. TODO: P4RT libs missing, otherwise sai-thrift server builds. * Progress on sai-thrift server, final saiserver linkage still has errors but was able to pass grpc/proto/pi libs into make. * Created init_switch test program and make target to initialize bmv2 model (P4RUntime SetForwardingPipelineRequest) to allow explicit switch intialization via P4Runtime. Removed sudo from most Make commands. READMEs. * Remove dependency to avoid rebuilding files while running test in CI. Delete stray file. * README * Build saithrift-bldr in Ubuntu-20.04 to avoid glibcc conflicts wth libgrpc etc. Modify sai-thrift Maefile to accomodate Python3 vs Python2. TODO - saiserver builds but get errors in later stages of make saithrift-build target (ctypesgen...) * Can build and run saithrift server. Fixed makefiles to call SAI makes with proper env vars etc., fixed install steps. * Add sai-thrift-server to CI job. * saithrift server starts up properly - added volume mounts to p4info * Add DOCKER_FLAGS for sai targets * Add sai-thrift-server CI test. * Workaround for git repo ownership in CI. * Correct trigger path for CI. * Workaround for SAI submodule - fixed step name. * Change dir into SAI/SAI to make safe directory * Try safe directory from /dash * Remove -u root from CI flags, remove git safe directory. * ove lib dir creation to Makefile, remove from .pyu script - permission errors during CI. * Add back -privileged flag * ADd -u root to make sai in CI * Change CI docker flags, use sudo for python script to overcome perms. * Update SAI branch which fixes sairpcgen Makefiles (sai header include path). * Remove experimental sudo from bash script, clean up overwrite options from python script (leave such things to makefiles.) Still struggling with perms issues in CI script. * Try sudo in CI make sai step. * Try -u root in CI file and git config --global --add safe.directory in Makefile * Use "git config --global --add safe.directory /dash/dash-pipeline/SAI/SAI" per error message, even though it doesn't match actual path IMO. * Try git config --global --add safe.directory '*' in Makefile. * Temporarily skip make sai step, see if rest of pipeline runs. * REstore CI script, try sudo workarounds in Makefile. * fix chmod command * Remove -u root, use sudo calling python script. * fix chmod to a+rw and also commit bash script. * chown and git safe dirs script attempt * pass user to sudo * export user * FIx chown * More wrappers and scripts to solve CI git ownership issues. * REmove chown to try to fix "./checkenumlock.sh ...fatal: Unable to create '/dash/.git/modules/SAI/index.lock': Permission denied * remove git safe dirs, getting lockfile error in CI * REmove sudo calling python script; shotgun sudo for all CI steps. * REstore sudo for py script; add -u root, --privileged to flags in CI * Workaround, delete scripts in SAI/meta/Makefile which throw Git permission errors. * Add sudo for sai-thrift-server target due to -u roots above. Got past git repo errors via previous commit, yay! * Use sudo to avoid permissions problem in CI pipeline for SAI/rpc dir * chown in sai-thrift Makefile to overcome CI perms issues. * Change perms instead of chown in saithrift build. * Add missing DOCKER_FLAGS to sai-thrift-server target * Add DOCKER_FLAGS to CI step; remove obsolete wrapper scripts. * Pass DOCKER_FLAGS to make target for sai-thrift-server test * Use different SAI submodule branch (better name, synced to master). Add saithrift clean target to clean. * Remove extraneous permissions workarounds. * Update SAI submodule. * Dockerfile for saithrift test clients. * ADd CI for saithrift client docker * Add prerequisite builds steps for sai-thrift-client. Update drawing. * Build prerequisites first to make docker-saithrift-client * Add missing requirements.txt, make targets. * Progress with saithrift-client docker image, pytest, ptf test installation and skeletons. * Refactor pytest to use common theift Client class; run sai client tests in CI. NOte - need sai_api_query impl to avoid sai thrift server crashes. * Set docker flags for saithrift client test in CI * Docs, diagrams. saithrift workflows. * Use updated SAI dev branch to insert checks for NULL sai API funcs before calling them. Add simple test for switch attribute to prove thrift API working. * Hand-modified sai_api_query to return SAI_API_DASH_VNET apis. Should be auto-generated. * Use workaround for saithrift builder per opencomputeproject/SAI#1537. Reorganize nacent pytests to use fixtures to get saithrift client, put in directories, add custom markers, new README. * mark vnet test x-fail for CI * Update saithrift client docker image. * Add empty README for saithrift/ptf * Clean up make targets. * Permissions fixes (manually, not merged). Add gdb to sai-thrift-server docker. * Fix sai-thrift-server; got first RPC working (vnet). Slight refactoring of pytests (imports); fixed sai_api_query & made _impl structs non-static. * Fix path for sai-thrift-server according to new -w path in Makefile * Add CI triggers for all .py, .sh, .yml and requirements.txt. under test/ dir * Update to snappi-0.7.38 for fix #153 * Temporary workaround for container permissions issues per #143. Executes chmod as required. Permanent fix will require some Docker mods. * Update snappi to 0.7.38 in saithrift tests * FIx dangling merge conflicts in README. * s/sai-thrift/saithrift to for consistency. * Delete sai_test which was accidentally copied from SAI repo. * Fix #158 - libsai delete operation failure and log msg. THe test for error code was backwards and log message used same write updateType string for all operations. I fixed the compare and used a dynamic enum print method. * Modify vnet pytest case to create/delete. README. Makefile polishing. * Add more table create/deletes + cleanup to saithrift vnet test case * Assign container names in ixia-c deployments (append username) * Got preliminary PTF and Pytests including saithrift table accessors, packet echo tests. Removed ixia-c test as standalone test; now it runs as a pytest inside saithrift-client container so host tool installs are reduced (snappi, python, pip). * Add back missing line to build saithrift server. * Fix CI trigger, a prior merge messed this up. * Add deploy-ixiac to Makefile deps and CI steps to support pytests. * Refactor saithrift-client docker image into builder and runtime images; runtime client is always built locally, not pulled. Change python requirements to hardlink to DASH/test/requirements.txt. Change DOckerfile name for consistency. * Create tests/libsai dir and move "C++" tests there; fix typo in CI file. * Defer deploying ixia-c until PTF tests complete to see if CI tests fail less often, suspect CI runner limits are being strained. Tests fail sometimes w/o reason. * Moved saithrift tests under tests/ for consistency. * FIx path, paste errors which run tests. * Move requirements.txt to hardlink under tests (was under saithrift). Delete obs file. * READMEs (saithrift test framework), Makefile (fix dev tests). * READMEs - test workflows. * Fix paste error - README * READMEs - workflows. Diagram. Remove "make run-test," replaced by "make libsai-test." * Fix CI action; READMEs polish. * Minor README improvements; fix URL, diagrams (sirius->dash); improve Quick-start instructions. * Add back URL. * REmove python, pip install deps. * READMEs; move saithrift test scripts into subdirs; change verify_packets() to verify_packet() to avoid failing due to junk entering veths from host network. * Change CI job title Sirius->DASH * Update SAI submodule to rescind changes to SAI include paths for sairpcgen, wasn't needed after all. Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
richardyu-ms
pushed a commit
to richardyu-ms/SAI
that referenced
this pull request
Aug 4, 2022
opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com>
chrispsommers
added a commit
to chrispsommers/SAI
that referenced
this pull request
Aug 4, 2022
opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com>
richardyu-ms
added a commit
that referenced
this pull request
Aug 11, 2022
…#1552) (#1533) (#1514) (#1492) (#1558) (#1557) * Added missing dependencies required to run gensairpc.pl (#1492) Fixes #1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… (#1514) * [doc] Add SAI metadata introduction presentation (#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Saithriftv2 fixes for extensions (#1533) * [doc] Add SAI metadata introduction presentation (#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental to include path. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add VLAN and PortChannel test plan (#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [meta] Add sai_status_t to ancestry check (#1501) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * reset sleep time during turning up ports (#1502) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [saineighbor] Bulk API support for Neighbor entries (#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan testcases from Group6 to Group10 (#1506) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add thr missing API into saithriftv2 missing for syncd (#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan test case (#1510) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add more waiting time for test (#1511) * add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add read config_db.json (#1519) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [Fix]Add necessary test data file for sai test (#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Zitingguo/add lag test (#1522) * add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add teardown for testing multiple cases at a time (#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Added missing dependencies required to run gensairpc.pl (#1492) Fixes #1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Update saitam.h (#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in #1531. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> * [SAI-PTF]Align the sai rpc front name with swss and syncd (#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Check for NULL APIs returned by sai_api_query() before calling. (#1558) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com>
richardyu-ms
added a commit
to richardyu-ms/SAI
that referenced
this pull request
Aug 27, 2022
…opencomputeproject#1552) (opencomputeproject#1533) (opencomputeproject#1514) (opencomputeproject#1492) (opencomputeproject#1558) (opencomputeproject#1557) * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… (opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Saithriftv2 fixes for extensions (opencomputeproject#1533) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental to include path. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add VLAN and PortChannel test plan (opencomputeproject#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [meta] Add sai_status_t to ancestry check (opencomputeproject#1501) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * reset sleep time during turning up ports (opencomputeproject#1502) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [saineighbor] Bulk API support for Neighbor entries (opencomputeproject#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan testcases from Group6 to Group10 (opencomputeproject#1506) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add thr missing API into saithriftv2 missing for syncd (opencomputeproject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan test case (opencomputeproject#1510) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add more waiting time for test (opencomputeproject#1511) * add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add read config_db.json (opencomputeproject#1519) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [Fix]Add necessary test data file for sai test (opencomputeproject#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Zitingguo/add lag test (opencomputeproject#1522) * add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add teardown for testing multiple cases at a time (opencomputeproject#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Update saitam.h (opencomputeproject#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in opencomputeproject#1531. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> * [SAI-PTF]Align the sai rpc front name with swss and syncd (opencomputeproject#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Check for NULL APIs returned by sai_api_query() before calling. (opencomputeproject#1558) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com>
richardyu-ms
added a commit
to richardyu-ms/SAI
that referenced
this pull request
Aug 27, 2022
…opencomputeproject#1552) (opencomputeproject#1533) (opencomputeproject#1514) (opencomputeproject#1492) (opencomputeproject#1558) (opencomputeproject#1557) * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… (opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Saithriftv2 fixes for extensions (opencomputeproject#1533) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental to include path. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add VLAN and PortChannel test plan (opencomputeproject#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [meta] Add sai_status_t to ancestry check (opencomputeproject#1501) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * reset sleep time during turning up ports (opencomputeproject#1502) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [saineighbor] Bulk API support for Neighbor entries (opencomputeproject#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan testcases from Group6 to Group10 (opencomputeproject#1506) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add thr missing API into saithriftv2 missing for syncd (opencomputeproject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan test case (opencomputeproject#1510) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add more waiting time for test (opencomputeproject#1511) * add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add read config_db.json (opencomputeproject#1519) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [Fix]Add necessary test data file for sai test (opencomputeproject#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Zitingguo/add lag test (opencomputeproject#1522) * add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add teardown for testing multiple cases at a time (opencomputeproject#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Update saitam.h (opencomputeproject#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in opencomputeproject#1531. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> * [SAI-PTF]Align the sai rpc front name with swss and syncd (opencomputeproject#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Check for NULL APIs returned by sai_api_query() before calling. (opencomputeproject#1558) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com>
richardyu-ms
added a commit
to richardyu-ms/SAI
that referenced
this pull request
Aug 28, 2022
…opencomputeproject#1552) (opencomputeproject#1533) (opencomputeproject#1514) (opencomputeproject#1492) (opencomputeproject#1558) (opencomputeproject#1557) * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… (opencomputeproject#1514) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Saithriftv2 fixes for extensions (opencomputeproject#1533) * [doc] Add SAI metadata introduction presentation (opencomputeproject#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental to include path. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add VLAN and PortChannel test plan (opencomputeproject#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (opencomputeproject#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [meta] Add sai_status_t to ancestry check (opencomputeproject#1501) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * reset sleep time during turning up ports (opencomputeproject#1502) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [saineighbor] Bulk API support for Neighbor entries (opencomputeproject#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan testcases from Group6 to Group10 (opencomputeproject#1506) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (opencomputeproject#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add thr missing API into saithriftv2 missing for syncd (opencomputeproject#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan test case (opencomputeproject#1510) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add more waiting time for test (opencomputeproject#1511) * add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add read config_db.json (opencomputeproject#1519) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [Fix]Add necessary test data file for sai test (opencomputeproject#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Zitingguo/add lag test (opencomputeproject#1522) * add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add teardown for testing multiple cases at a time (opencomputeproject#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Added missing dependencies required to run gensairpc.pl (opencomputeproject#1492) Fixes opencomputeproject#1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Update saitam.h (opencomputeproject#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in opencomputeproject#1531. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> * [SAI-PTF]Align the sai rpc front name with swss and syncd (opencomputeproject#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Check for NULL APIs returned by sai_api_query() before calling. (opencomputeproject#1558) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com>
richardyu-ms
added a commit
that referenced
this pull request
Aug 29, 2022
…#1552) (#1533) (#1514) (#1492) (#1558) (#1557) (#1589) * Added missing dependencies required to run gensairpc.pl (#1492) Fixes #1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Make… (#1514) * [doc] Add SAI metadata introduction presentation (#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> * Saithriftv2 fixes for extensions (#1533) * [doc] Add SAI metadata introduction presentation (#1487) Small presentation about SAI metadata features added in last time. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add GEN_SAIRPC_OPTS to pass flags to gensairpc.pl from top-level Makefile or meta/Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add static_cast<> to sairpcgen templates to avoid type mismatches for SAI extensions. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add new env variable SAIRPC_EXTRA_LIBS which gets passed to final linkage of saiserver, so user can pass in additional libraries. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental to include path. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add experimental headers to CPPFLAGS passed to ctypesgen. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add VLAN and PortChannel test plan (#1480) * Add VLAN and PortChannel test plan For vlan, it includes: 1. Vlan functionalities - Flooding - Forwarding - Trunk/Access - Tagging/Untagging(802.1Q) - VLAN interface (RIF/SVI) 2. SAI APIs operations - Vlan Counters - Vlan and member list operations For PortChannel, it includes: 1. Lag functionalities - Loadbalance 2. Lag SAI APIs - create/check/remove lag and lag member Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove cases not related to T0 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update lag_test_plan.md Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Add VLAN and Lag test plan and put topo config in seperated files Signed-off-by: richardyu <richardyu@contoso.com> * fix typo and more description more clear Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix lag test typo (#29) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor vlan test plan and config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor lag test plan (#33) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refactor pc and vlan test Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * Improve pc and vlan test Doc (#35) * fix typo Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * remove some unnecessary comments Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * reformat and adjust the description of the tests Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * set hash algorithm (#36) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * refine lag test (#37) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * correct vlan interface test (#38) Signed-off-by: zhoudongxu <Dongxu.Zhou@microsoft.com> * workaround for the sequence number issue in github and correct typo standardise the ip and mac naming in config add lag test for ingress port indifferenate in lag hash redesign the mac and ip namin convention and reformat Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * adjust the case numbers and vlan id Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [SAI-PTF] SAI PTF test structure for T0 test and VLAN,FDB sample cases (#1499) * [SAI-PTF] Add SAI ptf test structure for T0 test Create SAI PTF test structure for T0 1. Create configuration structure for different components configu 2. Add FDB, PORT, switch, vlan configurations 3. Create Test structure base on PTF 4. Add T0 test case samples for FDB Test Done: Checked the ports functionality with port flooding Checked port forwarding base on FDB configurations Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add vlan config and vlan test sample case Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add dx010 config Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [meta] Add sai_status_t to ancestry check (#1501) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * reset sleep time during turning up ports (#1502) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [saineighbor] Bulk API support for Neighbor entries (#1504) * Bulk support for Neighbor entries Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan testcases from Group6 to Group10 (#1506) Signed-off-by: Yang Wang <yangwang1@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. (#1497) Support counters on IP MC route entries. This is similar to the support added earlier for Route counters. API sequence: sai_attribute_t counter_attr; attr.id = SAI_COUNTER_ATTR_TYPE; attr.value.s32 = SAI_COUNTER_TYPE_REGULAR; sai_object_id_t counter_id; sai_status_t rc = sai_counter_api->create_counter(&counter_id, g_switch_id, 1, &attr); sai_attribute_t ipmc_attr; attr.id = SAI_IPMC_ENTRY_ATTR_COUNTER_ID; attr.value.oid = counter_id; rc = sai_ipmc_api->set_ipmc_entry_attribute(route_entry, ipmc_attr); sai_stat_id_t stat_ids[] = { SAI_COUNTER_STAT_PACKETS, SAI_COUNTER_STAT_BYTES }; uint64_t stats[2]; rc = sai_counter_api->sai_get_counter_stats_ext(counter_id, 2, stat_ids, stats); Signed-off-by: rck-innovium <rck@innovium.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Add thr missing API into saithriftv2 missing for syncd (#1484) saithriftv1 offers start_sai_thrift_rpc_server API to start the saithrift server and syncd is currently using that API https://github.com/Azure/sonic-sairedis/blob/master/syncd/syncd_main.cpp#L60 But this API is missing from the for saithriftv2. Made the relevant changes to provide a similar API for saithriftv2 library The start_sai_thrift_rpc_server API currently resides in saiserver.cpp which is not included in librpcserver.a and is not available for the users of the static library. Thus moved the function definition into sai_rpc_frontend.cpp for including it in the static library. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add vlan test case (#1510) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add vlan test case edit FilteringTest Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> edit vlan test case Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add more waiting time for test (#1511) * add more waiting time for test Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Update fdb_configer.py increase the waiting time for fdb entries update Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove useless change Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add read config_db.json (#1519) Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * [Fix]Add necessary test data file for sai test (#1520) In order to set up the port on different platforms, need to read the data for port configuration when turning on the admin state This PR is a bug fix for adding the config_db into test resources folder. Test Done: Test within SONiC mgmt container Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Zitingguo/add lag test (#1522) * add lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * enable lag config in test base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix lag config Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add remove_lag_member in lag_configer Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add sai_ipprefix() in utils Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * import LagConfiger in sai_test_base Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add a simple lag test Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix typo Signed-off-by: zitingguo <736034564@qq.com> * fix a config error in lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag lb test based on scr port Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix Signed-off-by: zitingguo <736034564@qq.com> * set lag v4 hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add lag disable egress test case Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add IndifferenceIngressPortTest Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * fix set hash function Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * separate route configuration from lag Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * disable setting lag hash Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * add virtual interface Signed-off-by: Ziting Guo <zitingguo@microsoft.com> Signed-off-by: zitingguo <736034564@qq.com> * Config default v4&v6 route Signed-off-by: zitingguo <736034564@qq.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * add teardown for testing multiple cases at a time (#1521) * add read config_db.json Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> format Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> addomment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> add comment for each function Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> * tear down Signed-off-by: ms-junyi <t-junyixiao@microsoft.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Added missing dependencies required to run gensairpc.pl (#1492) Fixes #1490 Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Update saitam.h (#1496) Attribute is introduced to configure IPFIX template reporting interval as per the RFC7011. https://datatracker.ietf.org/doc/html/rfc7011#section-8.4 Signed-off-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Pass SAIRPC_EXTRA_LIBS flag in Makefile Signed-off-by: Chris Sommers <chrispsommers@gmail.com> * Removed changes to include paths for SAI extension headers; as it turns out these changes were not required as originally reported in #1531. Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> * [SAI-PTF]Align the sai rpc front name with swss and syncd (#1552) In Syncd starting process, it will try to start the switch and assign the gSwtichId to the sai implementation. In the syncd rpc container, in order to get the swtich id after syncd initalization, we need to get and check the switch id. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * Check for NULL APIs returned by sai_api_query() before calling. (#1558) Signed-off-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com> Co-authored-by: Chris Sommers <chrispsommers@gmail.com> Co-authored-by: Kamil Cudnik <kcudnik@gmail.com> Co-authored-by: zhoudongxu <1315364814@qq.com> Co-authored-by: richardyu <richardyu@contoso.com> Co-authored-by: zhoudongxu <Dongxu.Zhou@microsoft.com> Co-authored-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Ravindranath C K <rck@innovium.com> Co-authored-by: Vivek R <vivekreddykarri98@gmail.com> Co-authored-by: ms-junyi <106718431+ms-junyi@users.noreply.github.com> Co-authored-by: zitingguo-ms <736034564@qq.com> Co-authored-by: Jai Kumar <jai.kumar@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1513.
Example showing how to pass option flags to
gensairpc.pl
from top-level makefile:Eventually, the make output shows that the
-ve
flags are passed togensairpc.pl