Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Diet: shrink images 80% and CI runtimes 50% #140

Merged
merged 55 commits into from
Jul 21, 2022
Merged

Docker Diet: shrink images 80% and CI runtimes 50% #140

merged 55 commits into from
Jul 21, 2022

Conversation

chrispsommers
Copy link
Collaborator

Refactored into multiple dockerfiles with smaller single-purpose images. Total size shrunk from 12.4GB initial image to 2.6GB, CI build time is <2 min instead of 4min mainly due to reduced docker pull times.

chrissommers/dash-p4c-bmv2          220701        7666a1aebede   3 hours ago         632MB
chrissommers/dash-bmv2-bldr         220630        4a4d042d0c24   24 hours ago        991MB
chrissommers/dash-saithrift-bldr    220625        90c05b660fe6   6 days ago          1.1GB

Temporary - this draft PR has modified p4 code in dash_pipeline.p4 to loop packets back out same port by default, may change before finalizing.

@chrispsommers
Build sai-thrift server (not working yet). New dockerfile.
4746311
@chrispsommers
Removed extraneous step.
9617024
@chrispsommers
README
efea557
@chrispsommers
Move Dockerfile under dockerfiles/
5aa8cd6
@chrispsommers
Pass flags to saithrift-build, expecting opencomputeproject/SAI#1514 …
3bde5d7 
…to merge eventually. Meanwhile can locally modify SAI makefiles.
@chrispsommers
Fix CI files for new location of Docekrfile.bmv2, add CI for dash-sai…
59eab6f 
…thrift docker.
@chrispsommers
Fix CI workflow for new dockerfiles.
f654cc7
@chrispsommers
Add line to trigger CI.
7070c85
@chrispsommers
Restore CI filename, try to get it to trigger.
992309b
@chrispsommers
Rename CI file; modify DOckerfile to trigger; add docker targets to M…
c31cfa1 
…akefile.
@chrispsommers
Modify dockerfiles to trigger CI.
a9ed085
@chrispsommers
Fix make target names in CI and Makefile
01203db
@chrispsommers
Update CI to trigger on CI file changes itself.
d3f3b3f
@chrispsommers
Trigger on CI file change.
82e744b
@chrispsommers
Merge remote-tracking branch 'upstream/main' into chris-saithrift3
058761d
@chrispsommers
Remove thrift source from dash-saithrift-bldr docker image. New tag 2…
d67ba61 
…20625.
@chrispsommers
Enhance saithrift docker to handle dash sai header generation and lib…
6702c8d 
…sai compilation.
@chrispsommers
Remove thrift source and source tarball from docker image; copy pytho…
2f40019 
…n dist tarball to /usr/lib inside container so can be extracted for deployment to a host.
@chrispsommers
Merge remote-tracking branch 'diana/main' into chris-saithrift4
eabc2ac
@chrispsommers
Experimenting with reduced Dockerfiles.
d450320
@chrispsommers
Makefile: p4 source dependencies. dash_pipeline.p4: egress_spec=ingre…
44262e6 
…ss_spec, comments.
@chrispsommers
Merge remote-tracking branch 'upstream/main' into chris-saithrift4
ae1c872
@chrispsommers
Fix stray merge conflict.
5f899c4
@chrispsommers
Fix merge conflict in CI file.
bc7ea6e
@chrispsommers
Optimized docker build and run images by creating a dedicated gRPC li…
71b1486 
…brary image and selectively copying to BMV2 builder/runtime image based on available p4lang docker image.
@chrispsommers
FIx CI, Makefile for new docker images.
431b39f
@chrispsommers
Optimize dockerfiles, reduced to 3 images totalling ~2.7G, down from …
9ab9cc3 
…~10G.
@chrispsommers
Fix CI files, add Make targets; cleanup.
d497889
@chrispsommers
CI files, badge
cfc2431
@chrispsommers
CI files.
311600c
@chrispsommers chrispsommers changed the title Optimize Docker images to decrease sizes and speed up CI. Optimize Docker images to shrink files and CI runtimes Jul 2, 2022
@chrispsommers chrispsommers changed the title Optimize Docker images to shrink files and CI runtimes Docker Diet: shrink images 75% and CI runtimes 50% Jul 2, 2022
@chrispsommers chrispsommers changed the title Docker Diet: shrink images 75% and CI runtimes 50% Docker Diet: shrink images 80% and CI runtimes 50% Jul 3, 2022
@chrispsommers
Ping SHA versions of Ubuntu used in base images.
c390b75
@chrispsommers
READMEs - workflows etc.
b766dc6
@chrispsommers
README typos, clarifications.
7f6a0c2
@chrispsommers
README
1b8c284
@chrispsommers
Use dev fork of SAI which passes flags to gensairpc.pl per opencomput…
6be1367 
…eproject/SAI#1514.

Once merged, we can change back to upstream branch of SAI.
@chrispsommers
Use fork of SAI with fixes for sairpcgen Make flags, and sairpcgen te…
309fba4 
…mplates which add static_cast to avoid type mismatches due to sai extensions.
@chrispsommers
Add placeholder code for SAI fixed functions, -fpermissive to avoid e…
662c2b1 
…num Long error. TODO: P4RT libs missing, otherwise sai-thrift server builds.
@chrispsommers
Created init_switch test program and make target to initialize bmv2 m…
b44955a 
…odel (P4RUntime SetForwardingPipelineRequest) to allow explicit switch intialization via P4Runtime. Removed sudo from most Make commands. READMEs.
@chrispsommers
Remove dependency to avoid rebuilding files while running test in CI.…
90313ee 
… Delete stray file.
@chrispsommers
README
aea869d
@chrispsommers
Merge remote-tracking branch 'upstream/main' into chris-saithrift4
6135411
@chrispsommers
Restore dash_pipeline.p4 to same as upstream. Had temporary changes (…
4a50d82 
…egress port = ingress port; comments).
@chrispsommers
Merge remote-tracking branch 'upstream/main' into chris-saithrift4
c569e9e
@chrispsommers
Merge remote-tracking branch 'upstream/main' into chris-saithrift4
499d55f
@chrispsommers
Add CI triggers for all .py, .sh, .yml and requirements.txt. under te…
a7aa311 
…st/ dir
@chrispsommers
Update to snappi-0.7.38 for fix sonic-net#153
6fb9728
@chrispsommers
Temporary workaround for container permissions issues per sonic-net#143…
ad1c0ae 
…. Executes chmod as required. Permanent fix will require some Docker mods.
@chrispsommers
Merge remote-tracking branch 'upstream/main' into chris-saithrift4
6c99c6a
@chrispsommers
Delete obxolete README, comment out WIP sai-thrift server make targets
e734681
@chrispsommers chrispsommers merged commit 3c1d634 into sonic-net:main Jul 21, 2022
@chrispsommers chrispsommers deleted the chris-saithrift4 branch July 25, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chrispsommers