fix the issue where port sai oid not correct when speed change is done from 400G to 100G #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic-net/sonic-buildimage#14706 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@rlhui we need to this for SAI 1.10 and need to backport for 202205 sonic-sairedis |
|
cc @anamehra for viz |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@arlakshm can you please help review this. |
abdosi
added a commit
that referenced
this pull request
Jul 13, 2023
Cherry-pick of Master PR: #1814 in v1.10 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@abdosi : Is this ported to on 1.12 as well, pls? |
abdosi
added a commit
that referenced
this pull request
Feb 15, 2024
abdosi
added a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Fixes: sonic-net/sonic-buildimage#14706
Why I did:
Without this change any HWSKU with native speed of 400G (8lanes) running as 100G port speed (4 lanes) the sai port oid are always return as NULL cauing all QOS test to fail.
How I did:
Change is generic where instead of doing exact match of lane value set return by SAI_PORT_ATTR_HW_LANE_LIST with the port_config.ini define value we are checking if it's subset of port_config.ini set.
How I verify:
Manual Verification.