sailibthrift is reading data from port_map.ini instead of config_db.json

[rraghav-cisco]

We encountered an issue where the sai-thrift library in syncd-rpc container in the SONiC image is reading the port information(lanes, speed) etc from the port_config.ini instead of the /etc/sonic/config_db.json. My understanding is that config_db.json is the place to read this information once it has been created and saved.

When the issue happens, the sai thrift call returns an empty value for port OID. I have attached the packet trace during this call.

Steps done:
We configured the port speeds and lanes for 8 ports (Ethernet96 to Ethernet152) from 400G to 100G. This was done in config_db.json, and then config-reload or reboot. The port_config.ini was not changed. This caused the following issue:

The below is the syslog that appears that time:
Apr 13 03:10:44.818545 chu-dut INFO syncd#/supervisord: message repeated 2 times: [ dshell_client [03:10:44] {/usr/bin/dshell_client.py:1676} INFO - sai_thrift_get_port_id_by_front_port]
Apr 13 03:10:44.818545 chu-dut INFO syncd#/supervisord: dshell_client [03:10:44] {/usr/bin/dshell_client.py:1676} INFO - Didn't find port
Apr 13 03:10:44.819073 chu-dut INFO syncd#/supervisord: dshell_client [03:10:44] {/usr/bin/dshell_client.py:1676} INFO - sai_thrift_get_port_id_by_front_port

This causes qos/test_qos.py::TestQosSai::testQosSaiSharedReservationSize to fail. The sai-port-id from the DUT is 0 for Ethernet96(one of the new 100G ports). You can see that Ethernet0 is returning a valid port ID, but Ethernet96 is returning 0. This is causing the script to fail.
root@chu-dut:/home/cisco# show int stat | grep "96 "
Ethernet96 1536,1537,1538,1539 100G 9100 rs etp12 PortChannel102 up up QSFP28 or later off
Ethernet196 260,261,262,263 100G 9100 N/A etp24b routed up down QSFP-DD Double Density 8X Pluggable Transceiver off

(Pdb) client.sai_thrift_get_port_id_by_front_port("Ethernet96")
0
(Pdb) client.sai_thrift_get_port_id_by_front_port("Ethernet0")
72057594037927956
(Pdb)
This issue is happening in all the new 100G ports:
(Pdb) for i in range(96,153,8): client.sai_thrift_get_port_id_by_front_port("Ethernet"+str(i))
0
0
0
0
0
0
0
0
(Pdb) client.sai_thrift_get_port_id_by_front_port("Ethernet160") <<< Normal port.
72057594037927980
(Pdb)

[rraghav-cisco]

Valid port ID for Ethernet0:


Invalid port ID for Ethernet96

[anamehra]

Hi @abdosi , raised this issue for saithrift lib causing qos test case failure when using minigraph as port_config.ini is used to validate the link.

[neethajohn]

@rraghav-cisco , @abdosi , can you provide more context?

[neethajohn]

@neethajohn to sync with @Gfrom2016 to understand this issue

[abdosi]

@Gfrom2016 have fixed this. Please check.
cc @neethajohn / @vmittal-msft / @anamehra /@rraghav-cisco for viz.