Consistently version media types #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Build is broken. |
The media type (application/vnd.oci.descriptor.v1+json) is versioned, so version the Go type. I don't see anything else that we need to add to descriptors, but it's probably better to be safe and version it anyway ;). Signed-off-by: W. Trevor King <wking@tremily.us>
These media types are defined in the versioned specs-go/v1/mediatype.go, and we may conceivably adjust the layer spec in the future. Generated with: $ sed -i 's|application/vnd.oci.image.layer.tar|application/vnd.oci.image.layer.v1.tar|g' \ > $(git grep -l application/vnd.oci.image.layer.tar) $ sed -i 's|application/vnd.oci.image.layer.nondistributable.tar|application/vnd.oci.image.layer.nondistributable.v1.tar|g' > $(git grep -l application/vnd.oci.image.layer.nondistributable.tar) Signed-off-by: W. Trevor King <wking@tremily.us>
Generated with: $ make img/media-types.png and Graphviz version 2.38.0. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
versioned-media-types
branch
from
7366057 to
4e31348
Compare
|
lgtm |
|
LGTM |
|
other @opencontainers/image-spec-maintainers PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
Descriptorand use .v1 for the layer media types defined inspecs-go/v1/mediatype.go.Fixes #338.