Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to work with new layer media type #56

Closed
wants to merge 1 commit into from
Closed

Update dependencies to work with new layer media type #56

wants to merge 1 commit into from

Conversation

glestaris
Copy link
Contributor

Since opencontainers/image-spec#347 the layer media type has been changed. This commit bumps the image-spec and dependencies.

@glestaris
Update dependencies
c648aee 
Since opencontainers/image-spec#347 the layer media
type has been changed. This commit bumps the image-spec and dependencies.

Signed-off-by: George Lestaris <glestaris@gmail.com>
@wking
Copy link
Contributor

wking commented Oct 25, 2016

On Tue, Oct 25, 2016 at 01:43:45PM -0700, George Lestaris wrote:

M vendor/github.com/opencontainers/runtime-spec/specs-go/config.go (44)
M vendor/github.com/opencontainers/runtime-spec/specs-go/state.go (2)
M vendor/github.com/opencontainers/runtime-spec/specs-go/version.go (2)

Can we pin runtime-spec in glide.yaml? I don't think the current repo
is stable enough to leave our dependency floating (with
incompatible-Go changes between Go changes breaking the current
patch-level comparison [1,2]). And the runtime-spec versions are
versioning the config format anyway (opencontainers/runtime-spec#523),
so we shouldn't expect them to apply to the Go bindings.

@cyphar cyphar mentioned this pull request Oct 26, 2016
Open
@wking wking mentioned this pull request Nov 2, 2016
Merged
@runcom
Copy link
Member

runcom commented Nov 3, 2016

is this a duplicate of #69 ?

@wking
Copy link
Contributor

wking commented Nov 3, 2016

Yes.

@glestaris
Copy link
Contributor Author

I'll close this one since #69 seems to work better with @wking's request :)

@glestaris glestaris closed this Nov 3, 2016
@glestaris glestaris deleted the update-deps branch November 3, 2016 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glestaris @wking @runcom