specs-go/v1: add annotations field to descriptor #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
9bdb5c5 looks good to me.
#501 also left them out of the schema, but #533 is fixing that missing
piece [1].
[1]: #533 (comment)
|
|
LGTM |
|
bump |
|
LGTM |
Merged
vbatts
reviewed
Feb 13, 2017
specs-go/v1/descriptor.go
Outdated
| @@ -30,4 +30,7 @@ type Descriptor struct { | |||
|
|
|||
| // URLs specifies a list of URLs from which this object MAY be downloaded | |||
| URLs []string `json:"urls,omitempty"` | |||
|
|
|||
| // Annotations contains arbitray metadata relating to the targeted content. | |||
| Annotations map[string]string | |||
There was a problem hiding this comment.
from #570, this ought to have json:"annotations,omitempty"
stevvooe
force-pushed
the
annotations-field-on-descriptor
branch
from
9bdb5c5 to
9bbe0dd
Compare
|
@vbatts Added |
|
LGTM |
jonboulle
reviewed
Feb 15, 2017
specs-go/v1/descriptor.go
Outdated
| @@ -30,4 +30,7 @@ type Descriptor struct { | |||
|
|
|||
| // URLs specifies a list of URLs from which this object MAY be downloaded | |||
| URLs []string `json:"urls,omitempty"` | |||
|
|
|||
| // Annotations contains arbitray metadata relating to the targeted content. | |||
Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
annotations-field-on-descriptor
branch
from
9bbe0dd to
c14c499
Compare
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day stephen.day@docker.com
@opencontainers/image-spec-maintainers PTAL