spec-go: Add "Annotations" field to Descriptor. #570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
suggested changes
Feb 13, 2017
specs-go/v1/descriptor.go
Outdated
| @@ -30,4 +30,7 @@ type Descriptor struct { | |||
|
|
|||
| // URLs specifies a list of URLs from which this object MAY be downloaded | |||
| URLs []string `json:"urls,omitempty"` | |||
|
|
|||
| // Annotations contains arbitrary metadata for the manifest list. | |||
There was a problem hiding this comment.
think it's better to change manifest list to descriptor.
There was a problem hiding this comment.
Sorry for my bad, fixed it, thanks!
Signed-off-by: Qian Zhang <zhq527725@gmail.com>
|
Dup #551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
84b6a28 added annotations to descriptor.md, we need to add it to spec-go accordingly as well.
Signed-off-by: Qian Zhang zhq527725@gmail.com