Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgroups.Resources.Unified support wrt systemd driver #2603

Closed
kolyshkin opened this issue Sep 28, 2020 · 2 comments · Fixed by #2669
Closed

Cgroups.Resources.Unified support wrt systemd driver #2603

kolyshkin opened this issue Sep 28, 2020 · 2 comments · Fixed by #2669

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented Sep 28, 2020

Initial support for cgroupv2 unified resources was merged in #2584.

With that in place, one can set, say, linux.resources.unified.pids.max = 42 which will make runc to write 42 to pids.max. The problem is, systemd TasksMax will still be unset/unlimited.

The issue can be solved by adding a map of some known "unified" parameters
to systemd properties.

Alternatively, we can forget about systemd properties and implement #2602 instead (which AFAIK is what crun does).

@AkihiroSuda
Copy link
Member

implement #2602 instead (which AFAIK is what crun does).

👍

@kolyshkin
Copy link
Contributor Author

kolyshkin commented Oct 1, 2020

Copy/pasting my comment from #2602 (comment)

OK so we have discussed it with @mrunalp and @giuseppe and looks like we can proceed with the plan outlined in #2603.

The biggest concern about switching systemd drivers to create a sub-cgroup is that software that uses libcontainer (kubelet etc.) might break. We could do it as an option but I don't think there will be any benefit.

So that's the plan for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants